Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1muon offline dqm harvesting config fix #19226

Merged

Conversation

thomreis
Copy link
Contributor

This fixes the issue that the L1 muon offline DQM harvesting module was not run in the common DQM workflow.

The L1TEgamma harvesting was moved into the Stage2l1TriggerDqmOfflineClient sequence since it does not need to run for legacy workflows.

cms.EDAnalyzer harvesting modules that were merged after the change to DQMEDHarvester have been migrated.

Replacement of couts with LogInfo.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

DQM/L1TMonitorClient
DQMOffline/Configuration
DQMOffline/L1Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@threus, @kreczko, @rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@rekovic
Copy link
Contributor

rekovic commented Jun 15, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 15, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20585/console Started: 2017/06/15 09:00

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@rekovic
Copy link
Contributor

rekovic commented Jun 15, 2017

@thomreis
Do we now have successfully created muon efficiency plots offline, that were otherwise failing to be made in production?

@thomreis
Copy link
Contributor Author

@rekovic yes, at least in my tests it works. The sequence with the module was not executed before.

Do you know which workflow of the matrix tests runs the DQM that is also running at the T0? I could not find one that suited me and had to adjust the cmsDriver command to test.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19226/20585/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1818841
  • DQMHistoTests: Total failures: 34144
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1784531
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@dmitrijus
Copy link
Contributor

+1

@rekovic
Copy link
Contributor

rekovic commented Jun 19, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@rekovic
Copy link
Contributor

rekovic commented Jun 19, 2017

@thomreis
It looks like workflow 136.731 runs on 2016 data and runs the DQM.

@thomreis
Copy link
Contributor Author

@rekovic 136.731 runs the DQM, yes, but not the harvesting that is done at the T0 (called @common). I noticed that the efficiency histograms for L1TEgamma are produced at the T0 but not when running 136.731.

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 648186f into cms-sw:master Jun 19, 2017
@thomreis thomreis deleted the l1muon_offline_dqm_harvesting_config_fix branch July 12, 2017 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants