Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTPPS: fix of event-bound adjustment #19261

Merged
merged 1 commit into from Jul 25, 2017

Conversation

jan-kaspar
Copy link
Contributor

This PR addresses the issue reported during reprocessing of Run2016H:
https://hypernews.cern.ch/HyperNews/CMS/get/prep-ops/3940/1/1/1/1/1/1/1.html

The functionality was verified with RecoCTPPS/Configuration/test/raw_data_test.py reading in /store/data/Run2016H/MuonEG/RAW/v1/000/283/820/00000/CEC46E92-CF9A-E611-B8A9-FA163EBBFF25.root.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jan-kaspar for CMSSW_8_0_X.

It involves the following packages:

CondFormats/CTPPSReadoutObjects

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @ggovi, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Jun 15, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 15, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20621/console Started: 2017/06/15 23:34

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19261/20621/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 16
  • DQMHistoTests: Total histograms compared: 1164335
  • DQMHistoTests: Total failures: 1202
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1163015
  • DQMHistoTests: Total skipped: 118
  • DQMHistoTests: Total Missing objects: 0
  • Checked 63 log files, 14 edm output root files, 16 DQM output files

@ggovi
Copy link
Contributor

ggovi commented Jun 21, 2017

+1

@arunhep
Copy link
Contributor

arunhep commented Jun 30, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

cmsbuild added a commit that referenced this pull request Jul 11, 2017
CTPPS: fix of event-bound adjustment (foward-port of #19261)
@forthommel
Copy link
Contributor

Hello @davidlange6
Can we know what is the current status of your review? Could we proceed with this PR integration?

@jan-kaspar
Copy link
Contributor Author

@davidlange6 Is there something we can do for this PR? Thanks!

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit eab5df7 into cms-sw:CMSSW_8_0_X Jul 25, 2017
@forthommel forthommel deleted the ctpps_event_bound_fix_8_0_X branch July 25, 2017 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants