New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing include for DOMNode.hpp to MiscalibReaderFromXMLDomUtils.h #19272
Add missing include for DOMNode.hpp to MiscalibReaderFromXMLDomUtils.h #19272
Conversation
The MiscalibReaderFromXMLDomUtils.icc file we include in this file tries to access the getNodeValue() method of a DOMNode, so we also need to include the related header to make this header compile on it's own.
Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile. |
A new Pull Request was created by @Teemperor (Raphael Isemann) for master. It involves the following packages: CalibCalorimetry/CaloMiscalibTools @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
@cmsbuild please abort |
Jenkins tests are aborted. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
The MiscalibReaderFromXMLDomUtils.icc file we include in this file
tries to access the getNodeValue() method of a DOMNode, so we also
need to include the related header to make this header compile
on it's own.