Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basicHepMCHeavyIonValidation to validationHI #1928

Merged
merged 1 commit into from Feb 5, 2014
Merged

Add basicHepMCHeavyIonValidation to validationHI #1928

merged 1 commit into from Feb 5, 2014

Conversation

BetterWang
Copy link
Contributor

Add basicHepMCHeavyIonValidation to validationHI.
This will generate DQM plots under Generator/HeavyIon folder for HeavyIon scenario.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 1, 2014

A new Pull Request was created by @BetterWang for CMSSW_5_3_X.

Add basicHepMCHeavyIonValidation to validationHI

It involves the following packages:

Validation/Configuration

@civanch, @thspeer, @deguio, @danduggan, @mdhildreth, @cmsbuild, @anton-a, @nclopezo, @rovere, @giamman, @slava77, @eliasron can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@smuzaffar you are the release manager for this.

@deguio
Copy link
Contributor

deguio commented Jan 9, 2014

+1

1 similar comment
@civanch
Copy link
Contributor

civanch commented Jan 20, 2014

+1

@BetterWang
Copy link
Contributor Author

Hi all, can we also get this signed off?
Thanks, Quan

@davidlange6
Copy link
Contributor

+1

@slava77
Copy link
Contributor

slava77 commented Feb 5, 2014

+1

based on 1df0f62
Signed off considering the DQM has approved this.
The changes are not relevant to RECO.

@smuzaffar
Copy link
Contributor

+tested

@slava77
Copy link
Contributor

slava77 commented Feb 5, 2014

Shahzad, did the tests include 40.0 (or another similar HI MC wflow)?
... is jenkins capable of running on 53X as well?

@smuzaffar
Copy link
Contributor

yes, I ran full runTheMatrix and it included wf 40.0 too.
Though Jenkin does not have 53X pull requests integration yet, but I
think it should be trivil to add it (I will do it right away).

Cheers,
--Shahzad
On 02/05/2014 04:43 PM, slava77 wrote:

Shahzad, did the tests include 40.0 (or another similar HI MC wflow)?
... is jenkins capable of running on 53X as well?


Reply to this email directly or view it on GitHub
#1928 (comment).

smuzaffar added a commit that referenced this pull request Feb 5, 2014
…_5_3_12_patch2

Add basicHepMCHeavyIonValidation to validationHI
@smuzaffar smuzaffar merged commit 574b8f1 into cms-sw:CMSSW_5_3_X Feb 5, 2014
@BetterWang BetterWang deleted the DQM_HepMCHeavyIon_from-CMSSW_5_3_12_patch2 branch April 15, 2014 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants