New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaning the Phase2TrackerDigi interface #19300
Cleaning the Phase2TrackerDigi interface #19300
Conversation
This method is deprecated, since channel() now does the same.
A new Pull Request was created by @delaere (Christophe Delaere) for master. It involves the following packages: DataFormats/Phase2TrackerDigi @perrotta, @cmsbuild, @slava77, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
-1 Tested at: 1328689 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test testTauEmbeddingProducers had ERRORS |
Comparison job queued. |
the unit test failure is unrelated to this PR |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
merge |
As discussed in the discussion of PR #19201, the packedPosition() method in Phase2TrackerDigi is not needed anymore. It is not used and now 100% similar to the channel() method.
The PR removes the method and replaces all of its occurrences by channel().
Absolutely no change is expected anywhere downstream.
@boudoul, @atricomi, @suchandradutta : FYI.