Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning the Phase2TrackerDigi interface #19300

Merged
merged 1 commit into from Jun 19, 2017

Conversation

delaere
Copy link
Contributor

@delaere delaere commented Jun 16, 2017

As discussed in the discussion of PR #19201, the packedPosition() method in Phase2TrackerDigi is not needed anymore. It is not used and now 100% similar to the channel() method.

The PR removes the method and replaces all of its occurrences by channel().
Absolutely no change is expected anywhere downstream.

@boudoul, @atricomi, @suchandradutta : FYI.

This method is deprecated, since channel() now does the same.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @delaere (Christophe Delaere) for master.

It involves the following packages:

DataFormats/Phase2TrackerDigi

@perrotta, @cmsbuild, @slava77, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Jun 16, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 16, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20650/console Started: 2017/06/16 17:42

@cmsbuild
Copy link
Contributor

-1

Tested at: 1328689

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19300/20650/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testTauEmbeddingProducers had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@slava77
Copy link
Contributor

slava77 commented Jun 16, 2017

the unit test failure is unrelated to this PR

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19300/20650/summary.html

Comparison Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1803170
  • DQMHistoTests: Total failures: 44326
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1758678
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jun 16, 2017

+1

for #19300 1328689

  • technical (removes redundant method)
  • jenkins tests pass (Reco comparison results: 0 differences found in the comparisons)

@kpedro88
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 18a3025 into cms-sw:master Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants