Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix for ill-defined ValueMaps in IsolatedTrack producer #19303

Merged
merged 1 commit into from Jun 17, 2017

Conversation

bjmarsh
Copy link
Contributor

@bjmarsh bjmarsh commented Jun 16, 2017

This fixes a small bug in #19025, pointed out here.

@smuzaffar

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bjmarsh (Bennett Marsh) for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @seemasharmafnal, @JyothsnaKomaragiri this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Jun 16, 2017

@cmsbuild please test

The fix looks simple enough
@bjmarsh thank you for the quick submission

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 16, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20654/console Started: 2017/06/16 20:08

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19303/20654/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1803136
  • DQMHistoTests: Total failures: 15085
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1787885
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jun 16, 2017

+1

for #19303 745fbb3

  • bugfix looks OK
  • jenkins tests pass (Reco comparison results: 0 differences found in the comparisons)
  • I confirm that the problem in TauAnalysis/MCEmbeddingTools goes away

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit ac7246f into cms-sw:master Jun 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants