Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Cluster charge and size per layer #19335

Merged
merged 1 commit into from Jun 20, 2017
Merged

Adding Cluster charge and size per layer #19335

merged 1 commit into from Jun 20, 2017

Conversation

fioriNTU
Copy link
Contributor

This PR adds plots of cluster charge and size for on-track and inclusive clusters (important for the commissioning of the pixel detector)

It also disable about 100 2D plots giving a quite redundant information

The final count of bins added/deleted is quite even

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fioriNTU for master.

It involves the following packages:

DQM/SiPixelPhase1Clusters
DQM/SiPixelPhase1Digis
DQM/SiPixelPhase1TrackClusters

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @hdelanno this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@dmitrijus
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 19, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20716/console Started: 2017/06/19 12:16

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19335/20716/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1802806
  • DQMHistoTests: Total failures: 29451
  • DQMHistoTests: Total nulls: 5706
  • DQMHistoTests: Total successes: 1767483
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 94667db into cms-sw:master Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants