Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix includes in DEutils.h #19342

Merged
merged 1 commit into from Jun 20, 2017
Merged

Conversation

Teemperor
Copy link
Contributor

We need to include MessageLogger.h here because we use edm::LogError.
We also need to include iomanip for the definition of std::setw that
we use in this file, as otherwise it won't compile on its own.

We need to include MessageLogger.h here because we use edm::LogError.
We also need to include iomanip for the definition of std::setw that
we use in this file, as otherwise it won't compile on its own.
@Teemperor
Copy link
Contributor Author

Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Teemperor (Raphael Isemann) for master.

It involves the following packages:

L1Trigger/HardwareValidation

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 19, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20734/console Started: 2017/06/19 17:48

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19342/20734/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1803170
  • DQMHistoTests: Total failures: 29333
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1773671
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit e8d5fda into cms-sw:master Jun 20, 2017
@Teemperor Teemperor deleted the FixIncludesDEutils.h branch December 19, 2017 08:47
@Teemperor Teemperor restored the FixIncludesDEutils.h branch December 19, 2017 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants