Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement async global end transitions #19366

Merged
merged 1 commit into from Jun 26, 2017
Merged

Implement async global end transitions #19366

merged 1 commit into from Jun 26, 2017

Conversation

Dr15Jones
Copy link
Contributor

Both global EndLuminosityBlock and global EndRun transitions are now run asynchronously.

@Dr15Jones
Implement async global end transitions
d9263a0 
Both global EndLuminosityBlock and global EndRun transitions are now run asynchronously.
@cmsbuild cmsbuild added this to the CMSSW_9_2_X milestone Jun 19, 2017
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/Framework
FWCore/Integration

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 19, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20744/console Started: 2017/06/19 18:26

@Dr15Jones
Copy link
Contributor Author

@davidlange6 this really should go into a development release, not the 9_2 production release.

@cmsbuild
Copy link
Contributor

+1
Tested at: d9263a0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19366/20744/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19366/20744/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1803170
  • DQMHistoTests: Total failures: 14513
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1788491
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@Dr15Jones
Copy link
Contributor Author

@smuzaffar @davidlange6 do I need to create an explicit pull request to _DEVEL?

@davidlange6
Copy link
Contributor

davidlange6 commented Jun 22, 2017 via email

@Dr15Jones
Copy link
Contributor Author

#19409 is the _DEVEL version of this same pull request.

@davidlange6
Copy link
Contributor

in DEVEL branch now.

@smuzaffar smuzaffar modified the milestones: CMSSW_9_3_X, CMSSW_9_2_X Jun 26, 2017
@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit d18eb61 into cms-sw:master Jun 26, 2017
@Dr15Jones
Copy link
Contributor Author

+1
just to get it off my search

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@Dr15Jones Dr15Jones deleted the asyncGlobalEndTransitions branch June 27, 2017 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available core-approved fully-signed orp-pending tests-approved
Projects
None yet
Milestone
CMSSW_9_3_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Dr15Jones @cmsbuild @davidlange6 @smuzaffar