Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the HeavyIon module that depends on TkDetMap #1943

Merged

Conversation

Dr15Jones
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 3, 2014

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_0_X.

Remove the HeavyIon module that depends on TkDetMap

It involves the following packages:

FWCore/Concurrency

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 3, 2014

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@Dr15Jones
Copy link
Contributor Author

@ktf I think this is is now the largest error type in the THREADED_X IB RelVals (certainly true for largest error with a fix). Putting this in can't affect anything else so I don't think there is a need to wait for testing.

@ktf
Copy link
Contributor

ktf commented Jan 5, 2014

Mmm... did you really mean to drop it from 70X? And not from the threaded branch?

@Dr15Jones
Copy link
Contributor Author

This 'customise' is only ever run in THREADED_X although the code itself has been in 7_0_X from the beginning.

ktf added a commit that referenced this pull request Jan 5, 2014
…kDetMap

Multithreading fixes -- Remove the HeavyIon module that depends on TkDetMap
@ktf ktf merged commit 3355350 into cms-sw:CMSSW_7_0_X Jan 5, 2014
@ktf
Copy link
Contributor

ktf commented Jan 5, 2014

Doh... I thought it was in the configuration...

@Dr15Jones Dr15Jones deleted the removeHeavyIonModulesThatUseTkDetMap branch January 17, 2014 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants