Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update online beamspot to quadruplet-only and rescale track uncertainties (92X) #19438

Merged
merged 5 commits into from Jul 6, 2017

Conversation

makortel
Copy link
Contributor

Backport of #19267. Original description:

This PR makes the following updates to the online beamspot applications making them more robust:

rescale pixel track parameter uncertainties to match better the reality
the uncertainties come from phase0 parametrization, so a difference wrt. phase1 is expected
@rovere tuned the scale factor such that the pulls of pixel vertex position coordinates were correct
do pixel tracks only from quadruplets
triplets produce too many fakes that introduce small biases in the beamspot position
enlargen the tracking region in Z from +- 3 cm to +- 6 cm
Tested in CMSSW_9_2_X_2017-06-09-1100. Should have no impact on runTheMatrix workflows.

@rovere @VinInn @mtosi @JanFSchulte @dinardo @sikler

rovere and others added 5 commits June 9, 2017 18:08
Avoid storing ParameterSet and parsing it once per event.

Remove "Quadruplets" from scaleErrorsForPhaseI as the rescaling is
inteded for both quadruplets and triplets when the first hit is on
BPix1.

Remove now-unused triplet configuration from the pixel tracking configuration.
This is more consistent as the scaling is done for BPix1, whereas it
is the scale factor value that is specific for phase1.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_9_2_X.

It involves the following packages:

DQM/Integration
RecoPixelVertexing/PixelTrackFitting

@perrotta, @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@batinkov, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @thomreis, @ebrondol, @threus, @dgulhan this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

backport of #19267

@slava77
Copy link
Contributor

slava77 commented Jun 27, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 27, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20941/console Started: 2017/06/27 17:52

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19438/20941/summary.html

Comparison Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1754229
  • DQMHistoTests: Total failures: 102
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1753961
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jun 27, 2017

+1

for #19438 ebacaf6

@slava77
Copy link
Contributor

slava77 commented Jul 5, 2017

@dmitrijus
please check this PR and comment or sign.
Thank you.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c8aff7c into cms-sw:CMSSW_9_2_X Jul 6, 2017
@makortel makortel deleted the BS_QuadOnly_ErrorRescaled branch February 12, 2018 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants