Xerces Memory Leak Cleanup

[ianna]

• Use cms::xerces::toString instead of xercesc::XMLString::transcode. The former has a custom deleter which deallocates memory. The latter would need an explicit memory deallocation.

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20936/console Started: 2017/06/27 12:44

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

CondFormats/CTPPSReadoutObjects

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @ggovi, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[ianna]

assign reconstruction

[cmsbuild]

New categories assigned: reconstruction

@slava77,@perrotta you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

+1
Tested at: 52c69b7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19442/20936/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
3b01ccc
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19442/20936/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19442/20936/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19442/20936/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 22
• DQMHistoTests: Total histograms compared: 1754263
• DQMHistoTests: Total failures: 15025
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1739072
• DQMHistoTests: Total skipped: 166
• DQMHistoTests: Total Missing objects: 0
• Checked 90 log files, 14 edm output root files, 22 DQM output files

[ianna]

@slava77 - comparison with baseline seems to be ok:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_9_3_X_2017-06-26-2300+19442/20896/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/CTPPS_TrackingStrip_sector%2045_station%20210_fr_hr_plane%2001.html

[ianna]

+1

[slava77]

On 6/27/17 9:39 AM, Ianna Osborne wrote: @slava77 <https://github.com/slava77> - comparison with baseline seems to be ok:

Hi Yana, I see that the implementation is different compared to the last attempt in #19041 Was that clearly buggy? Please clarify Thank you.

…

https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_9_3_X_2017-06-26-2300+19442/20896/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/CTPPS_TrackingStrip_sector%2045_station%20210_fr_hr_plane%2001.html — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19442 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEdcbvnKwk7Xsbz9VlsuTj1TQoJWc04zks5sITBZgaJpZM4OGbHf>.

[slava77]

+1

for #19442 52c69b7

• technical (and apparently correct this time)
• jenkins tests pass and comparisons show no differences
• I also checked that there are no differences in run 297292 which includes data from CTPPS pixels

[ianna]

@slava77 - yes, I just fixed the memory leak by eliminating transcode. Since it would require to write a test, I did not attempt to cleanup the code now, e.g. remove extra conversions to std::string and back to char* and their comparison. It can be done as a next step.

[arunhep]

+1