Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add track selection MVA plots to tracking DQM (92X) #19482

Merged
merged 3 commits into from Jul 6, 2017

Conversation

makortel
Copy link
Contributor

Backport of #19481. Original description:

This PR adds distributions and profiles vs. pT and eta of the track selection MVA output for each tracking iteration with an MVA track selection. For the cases where an iteration makes use of multiple MVA selectors (as in phase0), a similar logic is used as in MultiTrackValidator, i.e.

  • For the first MVA there is one histogram called "MVA1"
  • For the second MVA there are two histograms
    • "MVA2" for tracks not selected as loose by the first MVA
    • "MVA2HP" for tracks not selected as highPurity by the first MVA
  • Same for third MVA (and possibly onwards)

I also removed two obsolete configuration parameters (OutputMEsInRootFile and OutputFileName) to not hit the 255 parameter limit (and needing to modify the entire TrackingMonitor_cfi).

Tested in CMSSW_9_2_3. Expecting new histograms in phase0 and phase1, and no changes in phase2.

@rovere @VinInn @mtosi @hajohajo

To avoid hitting the 255 arguments limit with the upcoming
developments. (I know, I could switch to **dict([("key", "value")])
but I'd rather not overhaul the main configuration file).
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_9_2_X.

It involves the following packages:

DQM/TrackingMonitor
DQM/TrackingMonitorSource
RecoTracker/IterativeTracking
Validation/RecoTrack

@perrotta, @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @hdelanno, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @mtosi, @fioriNTU, @wmtford, @gpetruc, @idebruyn, @ebrondol, @threus, @dgulhan this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 29, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21007/console Started: 2017/06/29 18:43

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19482/21007/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1813696
  • DQMHistoTests: Total failures: 44263
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1769267
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Jul 4, 2017

+1

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8bc0d9e into cms-sw:CMSSW_9_2_X Jul 6, 2017
@makortel makortel deleted the dqmTrkMVA branch February 12, 2018 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants