Run2-TB33 Make recording of energy deposits in assive elements more usable

[bsunanda]

Add possibility of storing energy of particles leaving the setup

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HGCalCommonData
SimG4CMS/HGCalTestBeam

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20995/console Started: 2017/06/29 16:59
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20997/console Started: 2017/06/29 17:17

[cmsbuild]

+1
Tested at: 1cb504a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19483/20997/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
1974578
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19483/20997/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19483/20997/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19483/20997/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-19483/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17
• /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-19483/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D19_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D19+RecoFullGlobal_2023D19+HARVESTFullGlobal_2023D19

Comparison Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 22
• DQMHistoTests: Total histograms compared: 1756063
• DQMHistoTests: Total failures: 15029
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1740868
• DQMHistoTests: Total skipped: 166
• DQMHistoTests: Total Missing objects: 0
• Checked 90 log files, 14 edm output root files, 22 DQM output files

[kpedro88]

+1

[ianna]

+1

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[cmsbuild]

Pull request #19483 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please check and sign again.

[bsunanda]

@civanch This is used when the track leaves the setup - no postStepPoint etc. In any case I changed KE access from PreStepPoint

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21187/console Started: 2017/07/05 19:42

[civanch]

@bsunanda , G4Track is equivalent to PostStepPoint inside SD classes because the step is done.
By the way, the code may be simpler if use G4 method:

G4VPhysicalVolume* G4StepPoint::GetPhysicalVolume();
G4LogicalVolume* G4VPhysicalVolume::GetLogicalVolume();

there is no need in recent G4 to use Touchable in user code if you do not examine deep structure.

[cmsbuild]

+1
Tested at: b61854c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19483/21187/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
f194090
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19483/21187/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19483/21187/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19483/21187/summary.html

Comparison Summary:

• You potentially added 5 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 22
• DQMHistoTests: Total histograms compared: 1786918
• DQMHistoTests: Total failures: 29876
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1756876
• DQMHistoTests: Total skipped: 166
• DQMHistoTests: Total Missing objects: 0
• Checked 90 log files, 14 edm output root files, 22 DQM output files

[civanch]

+1

[kpedro88]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

+1