pr93x L1T fix L1T_ZeroBias not firing in RelVal MC. #19492

rekovic · 2017-06-30T07:14:14Z

pr93x L1T Fix the current problem with L1T_ZeroBias not firing in RelVals MC.

Description:
L1T_ZeroBias algorithm depneds on BPTX external conditions.
The Bptx external condition names have changed recently.
This fix is to add the new Bptx external condition names
in the External Conditions Producer.

Note:
A possible more elegant way of doing the same
would take more time, possibly updating the UTM
library.

Problem is discussed and documented in
cms-l1t-offline#571

rekovic · 2017-06-30T07:14:27Z

please test

cmsbuild · 2017-06-30T07:14:31Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21015/console Started: 2017/06/30 09:15

cmsbuild · 2017-06-30T07:14:33Z

A new Pull Request was created by @rekovic for master.

It involves the following packages:

L1Trigger/L1TGlobal

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

Martin-Grunewald · 2017-06-30T07:17:54Z

Could you please make a backport to 92X as well?
Thanks!

cmsbuild · 2017-06-30T08:14:59Z

+1
Tested at: bb1e171
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19492/21015/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
b493ac0
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19492/21015/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19492/21015/git-merge-result

cmsbuild · 2017-06-30T08:15:03Z

Comparison job queued.

arunhep · 2017-06-30T08:32:25Z

@franzoni @lpernie this is the fix for not firing L1_ZeroBias. You may want to follow this.

Martin-Grunewald · 2017-06-30T08:34:07Z

Hmm, while L1_ZeroBias now fires, I still see some 0 rates for som 'tech' bits:
though this might be expected on just 100 ttbar evets???

 =================  L1 Trigger Report  =====================================================================

 L1T menu Name   : L1Menu_Collisions2017_dev_r5
 L1T menu Version: 0.4
 L1T menu Comment: 2017 pp developing menu : processed with UTM 20170314

    Bit                  Algorithm Name                  Init    PScd  Final   PS Factor     Num Bx Masked
============================================================================================================
     240                  L1_SingleMuOpen_NotBptxOR         0      0      0         1          0
     241              L1_SingleMuOpen_NotBptxOR_3BX         0      0      0         1          0
     242              L1_SingleJet20er3p0_NotBptxOR         0      0      0         1          0
     243          L1_SingleJet20er3p0_NotBptxOR_3BX         0      0      0         1          0
     244          L1_SingleJet43er3p0_NotBptxOR_3BX         0      0      0         1          0
     245          L1_SingleJet46er3p0_NotBptxOR_3BX         0      0      0         1          0

     400                           L1_IsolatedBunch         0      0      0         1          0
     401                       L1_FirstBunchInTrain         0      0      0         1          0
     402                    L1_FirstBunchAfterTrain         0      0      0         1          0

     450                              L1_AlwaysTrue       100    100    100         1          0
     451                               L1_NotBptxOR         0      0      0         1          0
     452                                 L1_BptxXOR         0      0      0         1          0
     453                           L1_ZeroBias_copy       100    100    100         1          0
     454                   L1_BPTX_BeamGas_Ref1_VME         0      0      0         1          0
     455                   L1_BPTX_BeamGas_Ref2_VME         0      0      0         1          0
     456                     L1_BPTX_BeamGas_B1_VME         0      0      0         1          0
     457                     L1_BPTX_BeamGas_B2_VME         0      0      0         1          0
     458                                L1_ZeroBias       100    100    100         1          0
     459                                L1_BptxPlus       100    100    100         1          0
     460                               L1_BptxMinus       100    100    100         1          0
     461                                  L1_BptxOR       100    100    100         1          0
     462                       L1_BPTX_AND_Ref1_VME         0      0      0         1          0
     463                        L1_BPTX_B1NotB2_VME         0      0      0         1          0
     464                        L1_BPTX_B2NotB1_VME         0      0      0         1          0
     465                          L1_BPTX_NotOR_VME         0      0      0         1          0
     466                       L1_BPTX_AND_Ref2_NIM         0      0      0         1          0
     467                        L1_BPTX_B1NotB2_NIM         0      0      0         1          0
     468                        L1_BPTX_B2NotB1_NIM         0      0      0         1          0
     469                          L1_BPTX_NotOR_NIM         0      0      0         1          0
     470                       L1_BPTX_AND_Ref3_VME         0      0      0         1          0
     471                        L1_BPTX_OR_Ref3_VME         0      0      0         1          0
     472                         L1_BPTX_RefAND_VME         0      0      0         1          0
     473                   L1_FirstCollisionInOrbit         0      0      0         1          0
     474                       L1_BPTX_AND_Ref4_VME         0      0      0         1          0
     475                        L1_BPTX_OR_Ref4_VME         0      0      0         1          0
     476                    L1_LastCollisionInTrain         0      0      0         1          0
     477                   L1_FirstCollisionInTrain         0      0      0         1          0
     478                            L1_BPTX_AND_NIM         0      0      0         1          0
     479                             L1_BPTX_B1_NIM         0      0      0         1          0
     480                             L1_BPTX_B2_NIM         0      0      0         1          0
     481                             L1_BPTX_OR_NIM         0      0      0         1          0

rekovic · 2017-06-30T08:46:23Z

@Martin-Grunewald
Strange, for me L1T_ZeroBias does not fire, working in the old IB release CMSSW_9_2_X_2017-06-23-2300

Martin-Grunewald · 2017-06-30T08:49:10Z

I am using CMSSW_9_3_X_2017-06-29-2300 for the above log - as this is a master=93X PR (but we need a 92X PR as well :)

cmsbuild · 2017-06-30T10:06:23Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19492/21015/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 22
DQMHistoTests: Total histograms compared: 1756063
DQMHistoTests: Total failures: 17304
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1738593
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 90 log files, 14 edm output root files, 22 DQM output files

rekovic · 2017-06-30T12:12:06Z

OK. Checked with CMSSW_9_3_X_2017-06-29-2300 + this PR, and now I see L1_ZeroBias
fire.

 =================  L1 Trigger Report  =====================================================================

 L1T menu Name   : L1Menu_Collisions2017_dev_r5
 L1T menu Version: 0.4
 L1T menu Comment: 2017 pp developing menu : processed with UTM 20170314

    Bit                  Algorithm Name                  Init    PScd  Final   PS Factor     Num Bx Masked
============================================================================================================
     450                              L1_AlwaysTrue        10     10     10         0          0
     451                               L1_NotBptxOR         0      0      0         0          0
     452                                 L1_BptxXOR         0      0      0         0          0
     453                           L1_ZeroBias_copy        10     10     10         0          0
     454                   L1_BPTX_BeamGas_Ref1_VME         0      0      0         0          0
     455                   L1_BPTX_BeamGas_Ref2_VME         0      0      0         0          0
     456                     L1_BPTX_BeamGas_B1_VME         0      0      0         0          0
     457                     L1_BPTX_BeamGas_B2_VME         0      0      0         0          0
     458                                L1_ZeroBias        10     10     10         0          0
     459                                L1_BptxPlus        10     10     10         0          0
     460                               L1_BptxMinus        10     10     10         0          0
     461                                  L1_BptxOR        10     10     10         0          0

rekovic · 2017-06-30T12:44:05Z

@Martin-Grunewald
If you were referring to tech bits 240-245, I would not expect them to fire much.

The main concern was L1T_ZeroBias, so that is now OK.

rekovic · 2017-06-30T12:44:12Z

+1

cmsbuild · 2017-06-30T12:44:23Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

Martin-Grunewald · 2017-06-30T12:46:34Z

@rekovic
OK. But please make a PR for 92X asap. Thanks!

rekovic · 2017-06-30T12:49:08Z

@Martin-Grunewald

Done PR 92x, #19494.

Martin-Grunewald · 2017-06-30T12:51:27Z

@rekovic
Thanks!

davidlange6 · 2017-06-30T15:52:32Z

+1
(but maybe we can eventually do something smarter with these string comparisons?)

Add new Bptx external condition names

bb1e171

cmsbuild added this to the CMSSW_9_3_X milestone Jun 30, 2017

cmsbuild added comparison-pending l1-pending orp-pending pending-signatures tests-pending labels Jun 30, 2017

cmsbuild added tests-started and removed tests-pending labels Jun 30, 2017

cmsbuild added tests-approved and removed tests-started labels Jun 30, 2017

Martin-Grunewald mentioned this pull request Jun 30, 2017

HLT menu 2017 v1.1 #19235

Merged

rekovic mentioned this pull request Jun 30, 2017

L1T_ZeroBias not firing in MC ? cms-l1t-offline/cmssw#571

Open

cmsbuild added comparison-available and removed comparison-pending labels Jun 30, 2017

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels Jun 30, 2017

rekovic mentioned this pull request Jun 30, 2017

pr92x L1T fix L1T_ZeroBias not firing in RelVal MC. #19494

Merged

cmsbuild added orp-approved and removed orp-pending labels Jun 30, 2017

cmsbuild merged commit 096bdf0 into cms-sw:master Jun 30, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pr93x L1T fix L1T_ZeroBias not firing in RelVal MC. #19492

pr93x L1T fix L1T_ZeroBias not firing in RelVal MC. #19492

rekovic commented Jun 30, 2017 •

edited

rekovic commented Jun 30, 2017

cmsbuild commented Jun 30, 2017 •

edited

cmsbuild commented Jun 30, 2017

Martin-Grunewald commented Jun 30, 2017

cmsbuild commented Jun 30, 2017

cmsbuild commented Jun 30, 2017

arunhep commented Jun 30, 2017

Martin-Grunewald commented Jun 30, 2017 •

edited

rekovic commented Jun 30, 2017

Martin-Grunewald commented Jun 30, 2017 •

edited

cmsbuild commented Jun 30, 2017

rekovic commented Jun 30, 2017

rekovic commented Jun 30, 2017

rekovic commented Jun 30, 2017

cmsbuild commented Jun 30, 2017

Martin-Grunewald commented Jun 30, 2017

rekovic commented Jun 30, 2017

Martin-Grunewald commented Jun 30, 2017

davidlange6 commented Jun 30, 2017

pr93x L1T fix L1T_ZeroBias not firing in RelVal MC. #19492

pr93x L1T fix L1T_ZeroBias not firing in RelVal MC. #19492

Conversation

rekovic commented Jun 30, 2017 • edited

rekovic commented Jun 30, 2017

cmsbuild commented Jun 30, 2017 • edited

cmsbuild commented Jun 30, 2017

Martin-Grunewald commented Jun 30, 2017

cmsbuild commented Jun 30, 2017

cmsbuild commented Jun 30, 2017

arunhep commented Jun 30, 2017

Martin-Grunewald commented Jun 30, 2017 • edited

rekovic commented Jun 30, 2017

Martin-Grunewald commented Jun 30, 2017 • edited

cmsbuild commented Jun 30, 2017

rekovic commented Jun 30, 2017

rekovic commented Jun 30, 2017

rekovic commented Jun 30, 2017

cmsbuild commented Jun 30, 2017

Martin-Grunewald commented Jun 30, 2017

rekovic commented Jun 30, 2017

Martin-Grunewald commented Jun 30, 2017

davidlange6 commented Jun 30, 2017

rekovic commented Jun 30, 2017 •

edited

cmsbuild commented Jun 30, 2017 •

edited

Martin-Grunewald commented Jun 30, 2017 •

edited

Martin-Grunewald commented Jun 30, 2017 •

edited