New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly ignore threshold when requested #19531
Properly ignore threshold when requested #19531
Conversation
The default value of 0 for threshold will now properly stop the threshold checking.
@slava77 please double check the logic. |
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Services @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
On 7/3/17 1:53 PM, Chris Jones wrote:
@slava77 <https://github.com/slava77> please double check the logic.
looks fine, visually.
Thank you for the quick fix.
… —
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19531 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbkJhe7121WT_9f7p69HX2mPXya1Zks5sKVTPgaJpZM4OMrQ->.
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
The default value of 0 for threshold will now properly stop the threshold checking.