Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly ignore threshold when requested #19531

Merged

Conversation

Dr15Jones
Copy link
Contributor

The default value of 0 for threshold will now properly stop the threshold checking.

The default value of 0 for threshold will now properly stop the threshold checking.
@Dr15Jones
Copy link
Contributor Author

@slava77 please double check the logic.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/Services

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21106/console Started: 2017/07/03 22:55
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21107/console Started: 2017/07/03 23:14

@slava77
Copy link
Contributor

slava77 commented Jul 3, 2017 via email

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19531/21107/summary.html

Comparison Summary:

  • You potentially added 12 lines to the logs
  • Reco comparison results: 1773 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1756015
  • DQMHistoTests: Total failures: 46458
  • DQMHistoTests: Total nulls: 35
  • DQMHistoTests: Total successes: 1709356
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e2d2d83 into cms-sw:master Jul 4, 2017
@Dr15Jones Dr15Jones deleted the fixIgnoringThresholdInTimingService branch July 7, 2017 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants