Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCALDQM: more fixes for crashes due to calib channels, improve TP emulation, and minor plot adjustments #19547

Merged
merged 6 commits into from Jul 6, 2017

Conversation

DryRun
Copy link
Contributor

@DryRun DryRun commented Jul 4, 2017

  • Finish protecting against inclusion of calibration channels in QIE10/11DigiCollections. These can cause crashes when FEDs 1134 and 1135 are included in runs. (The previous PRs fixed most of these, but I unfortunately discovered a few more cases.)
  • As zero suppression to emulated TPs, to match what is done in data TPs.
  • PedestalTask has a filter to skip the laser/CRF/calibration channels crate. This was moved from crate 36 to 38, so the filter is updated accordingly (note that crate 36 is not in use anymore).
  • Small plot adjustments: fN_to4000 changed to fN_to8000 (this is used only to set the y-range for profile plots, so doesn't add bins), and fEtCorr_256 is changed from [-2,256] to [-1, 257] so that saturated bins aren't right on the edge.

This PR does not add any extra bins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2017

A new Pull Request was created by @DryRun (David Yu) for master.

It involves the following packages:

DQM/HcalCommon
DQM/HcalTasks
DQM/Integration

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @deguio, @threus, @batinkov, @thomreis this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21204/console Started: 2017/07/06 10:21

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19547/21204/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1787242
  • DQMHistoTests: Total failures: 14940
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 1772130
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2dfc973 into cms-sw:master Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants