-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase 2 - HGCal - Adding Energy above noise in RecHit #19572
Phase 2 - HGCal - Adding Energy above noise in RecHit #19572
Conversation
A new Pull Request was created by @felicepantaleo (Felice Pantaleo) for master. It involves the following packages: DataFormats/HGCRecHit @perrotta, @cmsbuild, @slava77, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@felicepantaleo : this PR indeed do imply some small effect on 2023 outputs, even before the last cosmetics: JR results differ 1 all_OldVSNew_TTbar14TeV2023D17wf20034p0 Changes are tiny, but do you have an explanation for them? Just to be sure that nothing leaked in inadvertently |
Ciao @perrotta, |
Overall, the size of step3.root increases by 0,46% (as in step3 of 20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D19 wf) In detail:
So, the new member signalOverSigmaNoise_ must be there, and take a non negligible amount of the HGCalRecHit size. What I find strange is that I am not able to see it in the step3 root output: root [8] Events->Draw("HGCRecHitsSorted_HGCalRecHit_HGCEERecHits_RECO.obj.obj.signalOverSigmaNoise()") What I am doing wrong? |
@perrotta just a sanity check, did you open the ROOT file after merging this PR and compiling? |
@kpedro88 : that's an extremely good point! |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
This PR adds the information about how many times the energy is above one sigma noise in a particular layer.
This information is useful at clustering level and downstream.
Please refer to the first couple of slides of this talk:
https://cernbox.cern.ch/index.php/s/iPYBFGAGtedNv6X
FYI @malgeri @rovere @cseez