Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix : adding JEC producers for AK5CHS and AK7CHS #1958

Merged
merged 1 commit into from Jan 10, 2014

Conversation

rappoccio
Copy link
Contributor

Here is a remaining bug fix after the pre-holiday JME madness. This adds AK5CHS and AK7CHS jet correction producers and services. This should not impact anything, it is parasitic and "analysis-level" at the moment.

This can go into 700 or whatever 71x pre release is up next.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2014

A new Pull Request was created by @rappoccio for CMSSW_7_0_X.

Bug fix : adding JEC producers for AK5CHS and AK7CHS

It involves the following packages:

JetMETCorrections/Configuration

@cmsbuild, @vadler, @Degano, @nclopezo can you please review it and eventually sign? Thanks.
@TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@vadler
Copy link

vadler commented Jan 7, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2014

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2014

This pull request is fully signed and it will be integrated in one of the next IBs unless changes (tests are also fine). @ktf can you please take care of it?

@ktf
Copy link
Contributor

ktf commented Jan 10, 2014

@vadler do you really need this for pre12?

@vadler
Copy link

vadler commented Jan 10, 2014

It just adds new module configs, but does not change event content or workflows. I let @rappoccio comment on the specific needs.

ktf added a commit that referenced this pull request Jan 10, 2014
Bug fix : adding JEC producers for AK5CHS and AK7CHS
@ktf ktf merged commit d1f6159 into cms-sw:CMSSW_7_0_X Jan 10, 2014
@rappoccio rappoccio deleted the rappoccio_700pre11_AddCHSJec branch November 3, 2014 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants