Fix crash from exception handling #19631
Conversation
The output module related functions were never actually called in the framework or testing.
The RunsInFileProcessor needs to be deleted before the FileResources so that endRun and endLuminosityBlock transitions happen before the OutputModules are told to close their files. With the wrong order, the OutputFiles close their files before they are told to write the LuminosityBlock. That was leading to a segmentation fault.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
The framework was giving the wrong order of operations to the OutputModules in the case of an exception. The OutputModules were told to close their output files before being told to write the LuminosityBlock.
This should fix the crashes seen in the IB RelVals.