clang check boost-use-to-string #19645
Conversation
|
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: CalibTracker/SiStripLorentzAngle @ghellwig, @ianna, @cerminar, @Martin-Grunewald, @rekovic, @vanbesien, @perrotta, @civanch, @silviodonato, @cmsbuild, @fwyzard, @davidlange6, @Dr15Jones, @mdhildreth, @slava77, @ggovi, @mulhearn, @vazzolini, @kmaeshima, @arunhep, @dmitrijus, @franzoni, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
please test |
|
-1 Tested at: 294f8bf The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found an error when building: >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/CSCObjects/test/stubs/CSCPedestalReadAnalyzer.cc
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/Serialization/interface/Archive.h:11:0,
from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/Serialization/interface/Test.h:9,
from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/Alignment/test/testSerializationAlignment.cpp:1:
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/Serialization/interface/eos/portable_oarchive.hpp: In function 'void testSerialization() [with T = unsigned int]':
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/Serialization/interface/eos/portable_oarchive.hpp:319:17: error: 'originalObject' may be used uninitialized in this function [-Werror=maybe-uninitialized]
if (T temp = t)
^
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/Alignment/test/testSerializationAlignment.cpp:1:0:
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-09-2300/src/CondFormats/Serialization/interface/Test.h:55:7: note: 'originalObject' was declared here
T originalObject;
The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
-1 this technically looks OK, but it should compile |
|
+1 |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 294f8bf The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found an error when building: >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-13-1100/src/CondFormats/CSCObjects/test/stubs/CSCCrossTalkReadAnalyzer.cc
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-13-1100/src/CondFormats/Serialization/interface/Archive.h:11:0,
from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-13-1100/src/CondFormats/Serialization/interface/Test.h:9,
from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-13-1100/src/CondFormats/Alignment/test/testSerializationAlignment.cpp:1:
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-13-1100/src/CondFormats/Serialization/interface/eos/portable_oarchive.hpp: In function 'void testSerialization() [with T = unsigned int]':
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-13-1100/src/CondFormats/Serialization/interface/eos/portable_oarchive.hpp:319:17: error: 'originalObject' may be used uninitialized in this function [-Werror=maybe-uninitialized]
if (T temp = t)
^
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-13-1100/src/CondFormats/Alignment/test/testSerializationAlignment.cpp:1:0:
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-13-1100/src/CondFormats/Serialization/interface/Test.h:55:7: note: 'originalObject' was declared here
T originalObject;
The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
please test |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-notrun
tests-rejected
labels
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
merge |
for comment about what clang-tidy does to CMSSW (and likely big and not mergeable - this is what clang-tidy check boost-use-to-string does on the tip of CMSSW_9_3_X as of a few days ago