Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --timing option in confdb.py (93X) #19720

Merged
merged 2 commits into from Jul 13, 2017

Conversation

Martin-Grunewald
Copy link
Contributor

Fix --timing option in confdb.py (93X)
Based on CMSSW_9_3_0_pre1

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for master.

It involves the following packages:

HLTrigger/Configuration

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @geoff-smith, @jalimena this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 13, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21422/console Started: 2017/07/13 10:42

@fwyzard
Copy link
Contributor

fwyzard commented Jul 13, 2017

won't this break the case of a configuration without the HLTriggerFirstPath ?

.A

@Martin-Grunewald
Copy link
Contributor Author

Hmm well, all configs should have it or take/import it from the master.
(I never liked that we recreate paths inside confdb.py which are identically in the menu).

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19720/21422/summary.html

Comparison Summary:

  • You potentially added 8 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 2021747
  • DQMHistoTests: Total failures: 15038
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2006543
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 93 log files, 14 edm output root files, 23 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2575532 into cms-sw:master Jul 13, 2017
@Martin-Grunewald Martin-Grunewald deleted the TimingOption93X branch August 31, 2017 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants