remove errant Eras.py imports

[kpedro88]

Modifiers should be implemented from their own cff files, not from Configuration.StandardSequences.Eras (to reduce unnecessary dependencies). See #14895.

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21455/console Started: 2017/07/13 21:37

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

DQM/HcalTasks
DQM/Physics
DQMOffline/Configuration
DQMOffline/L1Trigger
L1Trigger/L1TNtuples
RecoCTPPS/TotemRPLocal

@perrotta, @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @slava77, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@deguio, @rappoccio, @kreczko, @forthommel, @Martin-Grunewald, @thomreis, @rociovilar, @threus, @DryRun this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: e183ad7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19732/21455/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
9d873f4
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19732/21455/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19732/21455/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19732/21455/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 2021747
• DQMHistoTests: Total failures: 29450
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1992131
• DQMHistoTests: Total skipped: 166
• DQMHistoTests: Total Missing objects: 0
• Checked 93 log files, 14 edm output root files, 23 DQM output files

[dmitrijus]

+1

[slava77]

+1

for #19732 e183ad7

• technical
• jenkins tests pass

@smuzaffar @kpedro88 is there a way to implement a code rule that would prevent direct from Configuration.StandardSequences.Eras import eras ?

[kpedro88]

@slava77 I don't know of a way in Python to prevent imports, but there's some ongoing discussion in #14895 about permanent ways to avoid this problem in the future

[slava77]

On 7/17/17 11:42 AM, Kevin Pedro wrote: @slava77 <https://github.com/slava77> I don't know of a way in Python to prevent imports, but there's some ongoing discussion in #14895 <#14895> about permanent ways to avoid this problem in the future

we have QA scripts that parse parts of the code. While the import can not be prevented at execution level, it can still be noted by jenkins in the code rules or in a similar QA check.

…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19732 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEdcbmociSZA3cbQ_vkQcxUKy6YA7OIqks5sO6r4gaJpZM4OXchk>.

[davidlange6]

merge
one can always write a script to check for anything..but then you have to debug and maintain the script:)