Fix saveTags() and abs() use in HLTEgammaL1TMatchFilterRegional (92X)

[Martin-Grunewald]

Fix saveTags() and abs() use in HLTEgammaL1TMatchFilterRegional (92X)

[cmsbuild]

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_9_2_X.

It involves the following packages:

HLTrigger/Egamma

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[Martin-Grunewald]

backport of #19750

[Martin-Grunewald]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[Martin-Grunewald]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21502/console Started: 2017/07/15 12:11

[cmsbuild]

-1

Tested at: 08ab8a4

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4661813
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19752/21502/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19752/21502/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19752/21502/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

• AddOn:

I found errors in the following addon tests:

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4661813
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19752/21502/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19752/21502/git-merge-result

[cmsbuild]

Comparison job queued.

[Martin-Grunewald]

@smuzaffar
Jenkins claims an AddOnTest failed but does not say which one.
Could you please have a look?
I found in the hlt_data_pref test the following problem:

MSG


A fatal system signal has occurred: external termination request
The following is the call stack containing the origin of the signal.

but NO stack trace given.

I also can not reproduce the error running in my own developer area.
Could you please have a look whether maybe the external termination has been called by memory and/or cpu tine, and in this case extend?

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19752/21502/summary.html

Comparison Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 22
• DQMHistoTests: Total histograms compared: 1756608
• DQMHistoTests: Total failures: 29847
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1726595
• DQMHistoTests: Total skipped: 166
• DQMHistoTests: Total Missing objects: 0
• Checked 90 log files, 14 edm output root files, 22 DQM output files

[smuzaffar]

please test
I am asking to re-do the tests as there was some issues with jenkins over the weekend.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21506/console Started: 2017/07/17 09:41

[Martin-Grunewald]

+1
Can't reproduce jenkins error!

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[Martin-Grunewald]

type bugfix

[cmsbuild]

+1
Tested at: 08ab8a4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19752/21506/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4661813
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19752/21506/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19752/21506/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19752/21506/summary.html

Comparison Summary:

• You potentially added 7 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 22
• DQMHistoTests: Total histograms compared: 1756676
• DQMHistoTests: Total failures: 29844
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1726666
• DQMHistoTests: Total skipped: 166
• DQMHistoTests: Total Missing objects: 0
• Checked 90 log files, 14 edm output root files, 22 DQM output files

[davidlange6]

+1