Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the common sequence for PV validation #19753

Merged
merged 2 commits into from Aug 1, 2017

Conversation

hroskes
Copy link
Contributor

@hroskes hroskes commented Jul 14, 2017

also an interface for passing commands to the track hit filter in the validation configuration.

This has been in the common validation area for a while, so it's pretty well validated within the tracker alignment group

backport of #19751, but probably not much point testing until #19615 is merged.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hroskes (Heshy Roskes) for CMSSW_9_2_X.

It involves the following packages:

Alignment/OfflineValidation

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @davidlange6, @lpernie can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@franzoni
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 25, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21738/console Started: 2017/07/25 16:35

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19753/21738/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1766512
  • DQMHistoTests: Total failures: 14521
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1751825
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@arunhep
Copy link
Contributor

arunhep commented Jul 26, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2a5c864 into cms-sw:CMSSW_9_2_X Aug 1, 2017
@hroskes hroskes deleted the track-hit-filter-validation branch October 29, 2018 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants