Extra members in CSCCorrelatedLCTDigi to determine its original components #19786
Conversation
|
A new Pull Request was created by @dildick (Sven Dildick) for master. It involves the following packages: DataFormats/CSCDigi @civanch, @mdhildreth, @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 11a5395 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found an error when building: >> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-17-2300/src/L1Trigger/L1TMuonEndCap/src/PtAssignmentUnit.cc >> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-17-2300/src/L1Trigger/L1TMuonEndCap/src/PtRefinementUnitFactory.cc >> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-17-2300/src/L1Trigger/L1TMuonEndCap/src/ForestHelper.cc >> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-17-2300/src/L1Trigger/L1TMuonEndCap/src/EndCapParamsHelper.cc >> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-17-2300/src/L1Trigger/L1TMuonEndCap/src/PatternRecognition.cc error: class 'csctf::TrackStub' has a different checksum for ClassVersion 11. Increment ClassVersion to 12 and assign it to checksum 1100843423 Suggestion: You can run 'scram build updateclassversion' to generate src/DataFormats/L1CSCTrackFinder/src/classes_def.xml.generated with updated ClassVersion gmake: *** [tmp/slc6_amd64_gcc630/src/DataFormats/L1CSCTrackFinder/src/DataFormatsL1CSCTrackFinder/libDataFormatsL1CSCTrackFinder.so] Error 1 Leaving library rule at DataFormats/L1CSCTrackFinder >> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-17-2300/src/L1Trigger/L1TMuonEndCap/src/Tree.cc >> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-07-17-2300/src/L1Trigger/L1TMuonEndCap/src/Utilities.cc The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-notrun
tests-rejected
labels
|
Pull request #19786 was updated. @civanch, @mdhildreth, @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please check and sign again. |
|
I updated the class version of |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
Hi, are there more comments on this pull request? |
|
@rekovic Do you have any comments on this PR? |
|
+1 |
cmsbuild
added
fully-signed
l1-approved
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
merge |
dildick
deleted the
from-CMSSW_9_3_X_2017-07-17-1100-csc-lct-components
branch
When CSCCorrelatedLCTDigis are constructed, some information of the original CSCALCTDigi and CSCCLCTDigi gets lots. As a result is not easy to determine which ALCT and CLCT where involved in the LCT construction. In particular in Phase-2 scenarios where GEMPadDigis are combined with CSCALCTDigi and/or CSCCLCTDigi it becomes even more complicated to determine where the CSCCorrelatedLCTDigis came from. This pull request will make the task of debugging the emulator much easier.
I added a member
type_which can beIn addition I added members to get the original CSCALCTDigi, CSCCLCTDigi and GEMPadDigi.
Finally I deleted two implementations of
constructLCTs, one in CSCMotherBoardME11, one in CSCMotherBoardME11GEM. Both were unused in the algorithm.@Dr15Jones Referring to the discussion on the Framework and Edm Development HN, I find this implementation much more straightforward and easier to implement. Which is why I opted not to use edm::Ref.
@tahuang1991