Bug fix, following PR #19672

[igv4321]

Bug fix, see the discussion in PR #19672

[cmsbuild]

A new Pull Request was created by @igv4321 (Igor Volobouev) for master.

It involves the following packages:

RecoLocalCalo/HcalRecAlgos

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@mariadalfonso, @argiro this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test workflow 7.3

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21651/console Started: 2017/07/21 07:11

[cmsbuild]

+1
Tested at: 23e2ffd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19848/21651/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
2717209
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19848/21651/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19848/21651/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19848/21651/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 2347494
• DQMHistoTests: Total failures: 15188
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2332140
• DQMHistoTests: Total skipped: 166
• DQMHistoTests: Total Missing objects: 0
• Checked 93 log files, 14 edm output root files, 23 DQM output files

[slava77]

+1

for #19848 23e2ffd

• correctly assign parameters added in the fillDescriptions to be tracked
• jenkins tests pass
  • workflow 7.3 runs to completion
  • comparisons show no differences

the error in wf 7.3 present in the IB and fixed here was

Exception Message:
In the configuration, parameter "rejectAllFailures" is defined as a tracked bool.
It should be untracked.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

+1