Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EXOMONOPOLE Skim updates to 2017 triggers #19868

Merged
merged 2 commits into from Jul 27, 2017
Merged

EXOMONOPOLE Skim updates to 2017 triggers #19868

merged 2 commits into from Jul 27, 2017

Conversation

srimanob
Copy link
Contributor

EXOMONOPOLE Skim updates to 2017 triggers

@cmsbuild cmsbuild added this to the CMSSW_9_3_X milestone Jul 22, 2017
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

Configuration/Skimming

@cmsbuild, @kkousour, @davidlange6, @GurpreetSinghChahal, @fabozzi can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@srimanob srimanob mentioned this pull request Jul 22, 2017
Merged
@srimanob
Copy link
Contributor Author

@kfjack
Update the unprescaled trigger of the skim.

@fabozzi
Copy link
Contributor

fabozzi commented Jul 24, 2017

please test workflow 136.725

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 24, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21700/console Started: 2017/07/24 10:25

@cmsbuild
Copy link
Contributor

+1
Tested at: 009f81b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19868/21700/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
9a401ab
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19868/21700/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19868/21700/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@fabozzi
Copy link
Contributor

fabozzi commented Jul 24, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19868/21700/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 2355459
  • DQMHistoTests: Total failures: 29980
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2325313
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 93 log files, 14 edm output root files, 23 DQM output files

@davidlange6
Copy link
Contributor

hi @srimanob - should you not also keep the 2016 paths?

@srimanob
Copy link
Contributor Author

Hi @davidlange6
2 (of 3) paths does not exist anymore in 2017. Should I add them back, just for the history?

@davidlange6
Copy link
Contributor

davidlange6 commented Jul 26, 2017 via email

@cmsbuild
Copy link
Contributor

Pull request #19868 was updated. @cmsbuild, @kkousour, @davidlange6, @GurpreetSinghChahal, @fabozzi can you please check and sign again.

@srimanob
Copy link
Contributor Author

OK, thanks. I've updated this PR.

@fabozzi
Copy link
Contributor

fabozzi commented Jul 26, 2017

please test workflow 136.725

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 26, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21788/console Started: 2017/07/26 18:21

@cmsbuild
Copy link
Contributor

+1
Tested at: 3dd6a61
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19868/21788/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
cc98e01
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19868/21788/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19868/21788/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@fabozzi
Copy link
Contributor

fabozzi commented Jul 26, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19868/21788/summary.html

Comparison Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 2363781
  • DQMHistoTests: Total failures: 29587
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2334028
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 93 log files, 14 edm output root files, 23 DQM output files

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 5072a68 into cms-sw:master Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed orp-pending pdmv-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_3_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@srimanob @cmsbuild @fabozzi @davidlange6