New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make edmPythonConfigToCppValidation work with everything in Modules.py #19885
Conversation
A new Pull Request was created by @kpedro88 (Kevin Pedro) for master. It involves the following packages: FWCore/ParameterSet @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
@kpedro88 I assume you tested this on an existing class? |
please test |
Ah, never, mind. I had failed to read your pull request comment. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
@wddgit please also review |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
I read through it and did not notice any problems. +1 |
+1 |
The type check in
edmPythonConfigToCppValidation
is generalized to handle anything that inherits from_TypedParameterizable
. The tool can now handle any type defined in Modules.py.Tested on a
Service
and anESSource
:Fulfills issue #18425.