Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make edmPythonConfigToCppValidation work with everything in Modules.py #19885

Merged
merged 1 commit into from Jul 25, 2017

Conversation

kpedro88
Copy link
Contributor

The type check in edmPythonConfigToCppValidation is generalized to handle anything that inherits from _TypedParameterizable. The tool can now handle any type defined in Modules.py.

Tested on a Service and an ESSource:

edmPythonConfigToCppValidation $CMSSW_RELEASE_BASE/src/DQMServices/Components/python/DQMFastTimerServiceClient_cfi.py
edmPythonConfigToCppValidation $CMSSW_RELEASE_BASE/src/CalibCalorimetry/HcalPlugins/python/HBHEDarkening_cff.py

Fulfills issue #18425.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

FWCore/ParameterSet

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 24, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21716/console Started: 2017/07/24 18:28

@Dr15Jones
Copy link
Contributor

@kpedro88 I assume you tested this on an existing class?

@Dr15Jones
Copy link
Contributor

please test

@Dr15Jones
Copy link
Contributor

Ah, never, mind. I had failed to read your pull request comment.

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@Dr15Jones
Copy link
Contributor

@wddgit please also review

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19885/21716/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 2355459
  • DQMHistoTests: Total failures: 213
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2355080
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 93 log files, 14 edm output root files, 23 DQM output files

@wddgit
Copy link
Contributor

wddgit commented Jul 24, 2017

I read through it and did not notice any problems. +1

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b612170 into cms-sw:master Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants