gcc7 compilation warning(s) fix(es) in CommonTools/Utils #19898
Conversation
|
A new Pull Request was created by @mrodozov for master. It involves the following packages: CommonTools/Utils @perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
@mrodozov |
|
@slava77 yes sure I've noticed I'm using the branch name as commit message and I'll change the titles with more appropriate |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
mrodozov
changed the title
|
Comparison is ready Comparison Summary:
|
| @@ -23,8 +24,9 @@ namespace reco { | |||
| template<typename Object> | |||
| struct ValueOnObject { | |||
| virtual double eval(Object const&) const =0; | |||
| virtual ~ValueOnObject(){}; | |||
There was a problem hiding this comment.
in this file I also see CutOnObject and SelectIndecesInCollection with virtual methods and no virtual destructor defined.
Why?
Are these not used anywhere yet to trigger the warning?
It looks like these other types should have a destructor defined as well.
There was a problem hiding this comment.
glimps shows that these classes are not use (at least in cmssw).
>cmsglimpse CutOnObject
src/CommonTools/Utils/interface/ExpressionEvaluatorTemplates.h: struct CutOnObject {
>cmsglimpse SelectIndecesInCollection
src/CommonTools/Utils/interface/ExpressionEvaluatorTemplates.h: struct SelectIndecesInCollection {
@mrodozov , I would suggest to just add the missing destructor.
mrodozov
force-pushed
the
cmp-wngs-fix-CmnTls-Utils-gcc7
branch
from
b456894
to
d3c563d
Compare
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
merge |
Fix for compilation warning(s) when compiling with gcc7 and more flags listed here:
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc700/CMSSW_9_3_X_2017-07-24-2300/CommonTools/Utils