Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed transient/persistent argument mixup #1990

Merged

Conversation

Dr15Jones
Copy link
Contributor

The classes declared in classes_def.xml were meant not to be stored, however,
the wrong XML argument name was used. The used name was 'transient' but the
code actually only looks for the name 'persistent'. This change corrects the error.

The classes declared in classes_def.xml were meant not to be stored, however,
the wrong XML argument name was used. The used name was 'transient' but the
code actually only looks for the name 'persistent'. This change corrects the error.
@Dr15Jones
Copy link
Contributor Author

@ktf This is also needed for the THREADED_X build but is a real bug so I figured should go into 7_0_X. It should have no effect on any actual production jobs and if anyone had attempted to store such objects, ROOT would have crashed.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_0_X.

Fixed transient/persistent argument mixup

It involves the following packages:

PhysicsTools/FWLite

@cmsbuild, @vadler, @Degano, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@cmsbuild
Copy link
Contributor

@ktf
Copy link
Contributor

ktf commented Jan 11, 2014

@vadler I'm bypassing your signature. Complain if not ok.

ktf added a commit that referenced this pull request Jan 11, 2014
…csToolsFWLite

AT fix -- Fixed transient/persistent argument mixup
@ktf ktf merged commit 67ab40d into cms-sw:CMSSW_7_0_X Jan 11, 2014
@vadler
Copy link

vadler commented Jan 12, 2014

@ktf : No complaint.

@Dr15Jones Dr15Jones deleted the fixNonPersisentClassesInPhysicsToolsFWLite branch January 17, 2014 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants