gcc7 compilation warning(s) fix(es) in DataFormats/L1THGCal #19903
Conversation
|
A new Pull Request was created by @mrodozov for master. It involves the following packages: DataFormats/L1THGCal @cmsbuild, @rekovic, @mulhearn, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
merge |
| @@ -43,7 +43,9 @@ namespace l1t { | |||
| typedef std::vector<bool> data_payload; | |||
| typedef uint32_t key_type; | |||
|
|
|||
| HGCFETriggerDigi() : codec_((unsigned char)0xffff) {} | |||
| HGCFETriggerDigi() : codec_((unsigned char)0xffff) { | |||
| detid_ = 0; | |||
There was a problem hiding this comment.
The better way is to do it as part of the initializer list
HGCFETriggerDigi() : codec_((unsigned char)0xffff), detid_(0) {}
Fix for compilation warning(s) when compiling with gcc7 and more flags listed here:
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc700/CMSSW_9_3_X_2017-07-24-2300/L1Trigger/L1THGCal