Fix in TSGForOI muons - 93X #19948

silviodonato · 2017-07-28T11:11:50Z

92X version: #19947

Running hltIntegrationTests /dev/CMSSW_9_2_0/GRun/V94 -i root://cms-xrd-global.cern.ch//store/data/Run2017B/MuonEG/RAW/v1/000/297/469/00000/C0653517-2D59-E711-91CD-02163E0118F3.root -x "--globaltag 92X_dataRun2_HLT_v4" -x "--l1-emulator uGT --l1 L1Menu_Collisions2017_v2_m6_full_xml" -j16 -n100 -d hltintegrationTestV94 &>logIntegrationDataV94 &
we found inconsistencies between running full HLT menu and single HLT path.

This is due to some non-const members of TSGForOI that are not initialized at each event.

This PR is very important for the upcoming V2.1 menu.

cmsbuild · 2017-07-28T11:12:10Z

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

RecoMuon/TrackerSeedGenerator

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@bellan, @abbiendi, @jhgoh, @echapon, @calderona, @HuguesBrun, @battibass, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

silviodonato · 2017-07-28T11:12:37Z

please test

cmsbuild · 2017-07-28T11:12:52Z

The tests are being triggered in jenkins.

Martin-Grunewald · 2017-07-28T11:19:34Z

type bug-fix

Martin-Grunewald · 2017-07-28T11:19:40Z

urgent

slava77 · 2017-07-28T12:51:49Z

is v2.1 menu in the release already to have this PR actually tested with jenkins.
It seems from the PR description that the issue is related in part to the configuration of this module
[or configuration of the tests used previously that never enabled it]

silviodonato · 2017-07-28T12:56:49Z

Yes, the v2.1 HLT menu has been integrated in release with #19876.
Unfortunately, I think hltIntegrationTests in jenkins cannot spot this issue because you need to more statistic to see it.

slava77 · 2017-07-28T12:58:00Z

@cmsbuild please test

@smuzaffar I see "Schedule cmssw#19948" in the scheduling jobs
https://cmssdt.cern.ch/jenkins/job/ib-schedule-pr-tests/19497/console
but nothing in ib-any-integration
Please check what happened.

cmsbuild · 2017-07-28T12:58:20Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21855/console Started: 2017/07/28 14:58
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21861/console Started: 2017/07/28 15:30

slava77 · 2017-07-28T12:59:49Z

.. OK, this time it actually worked
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21855/console

silviodonato · 2017-07-28T13:04:36Z

hltIntegrationTests in IB validation: https://cmssdt.cern.ch/SDT/jenkins-artifacts/HLT-Validation/CMSSW_9_3_X_2017-07-27-2300/slc6_amd64_gcc630/

Martin-Grunewald · 2017-07-28T13:05:16Z

They are not run in PR/jenkins tests but in IB tests: "HLT Validation".
The statistics (-n 100) was still too small to detect that one, though.

cmsbuild · 2017-07-28T14:29:58Z

-1

Tested at: e04a72c

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
ee43b2f
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19948/21861/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19948/21861/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19948/21861/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following worklfows:
10042.0 step2

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step2_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10024.0 step2

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10824.0 step2

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log

AddOn:

I found errors in the following addon tests:

cmsRun /cvmfs/cms-ib.cern.ch/nweek-02482/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-28-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2e34_v2.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Jul 28 16:18:58 2017-date Fri Jul 28 16:08:37 2017 s - exit: 21248
cmsDriver.py RelVal -s HLT:2e34_v2,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_2e34_v2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_2e34_v2_MC.root --fileout file:RelVal_Raw_2e34_v2_MC_HLT_RECO.root : FAILED - time: date Fri Jul 28 16:18:58 2017-date Fri Jul 28 16:08:37 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02482/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-28-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Jul 28 16:15:33 2017-date Fri Jul 28 16:08:41 2017 s - exit: 21248
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Fri Jul 28 16:15:33 2017-date Fri Jul 28 16:08:41 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02482/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-28-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Jul 28 16:16:27 2017-date Fri Jul 28 16:08:44 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02482/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-28-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Jul 28 16:19:22 2017-date Fri Jul 28 16:08:49 2017 s - exit: 21248
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Fri Jul 28 16:19:22 2017-date Fri Jul 28 16:08:49 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02482/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-28-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Jul 28 16:17:37 2017-date Fri Jul 28 16:09:12 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02482/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-28-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Jul 28 16:21:38 2017-date Fri Jul 28 16:13:33 2017 s - exit: 21248
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Fri Jul 28 16:21:38 2017-date Fri Jul 28 16:13:33 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02482/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-28-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Jul 28 16:18:16 2017-date Fri Jul 28 16:13:41 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02482/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-28-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Jul 28 16:22:52 2017-date Fri Jul 28 16:16:29 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02482/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-28-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Jul 28 16:25:05 2017-date Fri Jul 28 16:19:07 2017 s - exit: 21248
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Fri Jul 28 16:25:05 2017-date Fri Jul 28 16:19:07 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02482/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-28-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2e34_v2.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Jul 28 16:25:40 2017-date Fri Jul 28 16:21:39 2017 s - exit: 21248
cmsDriver.py RelVal -s HLT:2e34_v2,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_2e34_v2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_2e34_v2_DATA.root --fileout file:RelVal_Raw_2e34_v2_DATA_HLT_RECO.root : FAILED - time: date Fri Jul 28 16:25:40 2017-date Fri Jul 28 16:21:39 2017 s - exit: 21248

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
ee43b2f
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19948/21861/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19948/21861/git-merge-result

cmsbuild · 2017-07-28T14:30:00Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2017-08-01T09:35:30Z

Comparison job queued.

slava77 · 2017-08-01T16:27:51Z

@cmsbuild please test

the last one failed with
Build timed out (after 360 minutes). Marking the build as aborted.

cmsbuild · 2017-08-01T16:28:11Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21982/console Started: 2017/08/01 19:43

cmsbuild · 2017-08-01T19:42:08Z

+1
Tested at: 644c0b8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19948/21982/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
ff15bd6
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19948/21982/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19948/21982/git-merge-result

cmsbuild · 2017-08-01T19:42:12Z

Comparison job queued.

slava77 · 2017-08-01T23:38:08Z

+1

for #19948 644c0b8

bug fixes in TSGForOI and migration of the module to a global
jenkins tests pass and comparisons show no differences since e04a72c
- local test with 136.782 (double muon 2017) confirms that there were no changes introduced since e04a72c
local tests with 2017 workflows show that the reco quantities are not affected and DQM comparisons with baseline show changes in HLT muon-related quantities expected from changes in this PR.

cmsbuild · 2017-08-02T00:36:06Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19948/21982/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 25
DQMHistoTests: Total histograms compared: 2651091
DQMHistoTests: Total failures: 46547
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2604363
DQMHistoTests: Total skipped: 181
DQMHistoTests: Total Missing objects: 0
Checked 102 log files, 14 edm output root files, 25 DQM output files

Martin-Grunewald · 2017-08-02T05:37:34Z

+1

cmsbuild · 2017-08-02T05:37:53Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

davidlange6 · 2017-08-02T08:14:14Z

+1

fix TSGForOI

e04a72c

cmsbuild added this to the CMSSW_9_3_X milestone Jul 28, 2017

cmsbuild added comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jul 28, 2017

silviodonato mentioned this pull request Jul 28, 2017

Fix in TSGForOI muons - 92X #19947

Merged

cmsbuild added tests-started and removed tests-pending labels Jul 28, 2017

cmsbuild added bug-fix urgent labels Jul 28, 2017

cmsbuild added tests-pending and removed tests-started labels Jul 28, 2017

cmsbuild added tests-started and removed tests-pending labels Jul 28, 2017

cmsbuild added tests-approved and removed tests-started labels Aug 1, 2017

cmsbuild added tests-pending tests-started and removed tests-approved tests-pending labels Aug 1, 2017

cmsbuild added tests-approved and removed tests-started labels Aug 1, 2017

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Aug 1, 2017

cmsbuild added comparison-available and removed comparison-pending labels Aug 2, 2017

cmsbuild added fully-signed hlt-approved and removed hlt-pending pending-signatures labels Aug 2, 2017

cmsbuild added orp-approved and removed orp-pending labels Aug 2, 2017

cmsbuild merged commit 3420a18 into cms-sw:master Aug 2, 2017

Martin-Grunewald deleted the FixTSGForOIMuons_93X branch September 7, 2017 13:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix in TSGForOI muons - 93X #19948

Fix in TSGForOI muons - 93X #19948

silviodonato commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

silviodonato commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

Martin-Grunewald commented Jul 28, 2017

Martin-Grunewald commented Jul 28, 2017

slava77 commented Jul 28, 2017

silviodonato commented Jul 28, 2017

slava77 commented Jul 28, 2017

cmsbuild commented Jul 28, 2017 •

edited

slava77 commented Jul 28, 2017

silviodonato commented Jul 28, 2017

Martin-Grunewald commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

cmsbuild commented Aug 1, 2017

slava77 commented Aug 1, 2017

cmsbuild commented Aug 1, 2017 •

edited

cmsbuild commented Aug 1, 2017

cmsbuild commented Aug 1, 2017

slava77 commented Aug 1, 2017

cmsbuild commented Aug 2, 2017

Martin-Grunewald commented Aug 2, 2017

cmsbuild commented Aug 2, 2017

davidlange6 commented Aug 2, 2017

Fix in TSGForOI muons - 93X #19948

Fix in TSGForOI muons - 93X #19948

Conversation

silviodonato commented Jul 28, 2017

92X version: #19947

cmsbuild commented Jul 28, 2017

silviodonato commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

Martin-Grunewald commented Jul 28, 2017

Martin-Grunewald commented Jul 28, 2017

slava77 commented Jul 28, 2017

silviodonato commented Jul 28, 2017

slava77 commented Jul 28, 2017

cmsbuild commented Jul 28, 2017 • edited

slava77 commented Jul 28, 2017

silviodonato commented Jul 28, 2017

Martin-Grunewald commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

cmsbuild commented Jul 28, 2017

cmsbuild commented Aug 1, 2017

slava77 commented Aug 1, 2017

cmsbuild commented Aug 1, 2017 • edited

cmsbuild commented Aug 1, 2017

cmsbuild commented Aug 1, 2017

slava77 commented Aug 1, 2017

cmsbuild commented Aug 2, 2017

Martin-Grunewald commented Aug 2, 2017

cmsbuild commented Aug 2, 2017

davidlange6 commented Aug 2, 2017

cmsbuild commented Jul 28, 2017 •

edited

cmsbuild commented Aug 1, 2017 •

edited