Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DetectorDescription Clang Check modernize-use-equals-delete #19978

Merged
merged 1 commit into from Aug 13, 2017
Merged

DetectorDescription Clang Check modernize-use-equals-delete #19978

merged 1 commit into from Aug 13, 2017

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Jul 31, 2017

Note: it should be taken after #19974

@ianna
Copy link
Contributor Author

ianna commented Jul 31, 2017

please test

@cmsbuild cmsbuild added this to the CMSSW_9_3_X milestone Jul 31, 2017
@ianna
Copy link
Contributor Author

ianna commented Jul 31, 2017

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @ianna
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 31, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21906/console Started: 2017/07/31 12:42

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/Core
DetectorDescription/RegressionTest

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Tested at: e6014ab

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
e289891
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19978/21906/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19978/21906/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19978/21906/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
1306.0 step4

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step4_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
e289891
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19978/21906/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19978/21906/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@ianna
Copy link
Contributor Author

ianna commented Aug 1, 2017

The removal error does not seem to be related to this PR:

31-Jul-2017 14:12:29 CEST  Initiating request to open file file:step3_inDQM.root
31-Jul-2017 14:12:32 CEST  Successfully opened file file:step3_inDQM.root
%MSG-e DQMGenericClient:  DQMGenericClient:postProcessorTrack@endJob  31-Jul-2017 14:14:47 CEST PostGlobalEndRun
 DQMGenericClient::findAllSubdirectories ==> Missing folder Tracking/TrackBHadron !!!
%MSG
%MSG-e DQMGenericClient:  DQMGenericClient:hltMuonPostNonIso@endJob  31-Jul-2017 14:15:14 CEST PostGlobalEndRun
 DQMGenericClient::findAllSubdirectories ==> Missing folder HLT/Muon/Distributions !!!
%MSG
%MSG-e DQMGenericClient:  DQMGenericClient:hltMuonPostIso@endJob  31-Jul-2017 14:15:15 CEST PostGlobalEndRun
 DQMGenericClient::findAllSubdirectories ==> Missing folder HLT/Muon/Distributions !!!
%MSG
%MSG-e DQMGenericClient:  DQMGenericClient:hltMuonPostMain@endJob  31-Jul-2017 14:15:15 CEST PostGlobalEndRun
 DQMGenericClient::findAllSubdirectories ==> Missing folder HLT/Muon/Distributions !!!
%MSG
%MSG-w EmDQMPostProcessor:  EmDQMPostProcessor:EgammaPostVal@endJob  31-Jul-2017 14:15:15 CEST PostGlobalEndRun
cannot find directory: HLT/HLTEgammaValidation , skipping
%MSG
%MSG-e DQMGenericClient:  DQMGenericClient:postProcessorHLTmuonTracking@endJob  31-Jul-2017 14:15:15 CEST PostGlobalEndRun
 DQMGenericClient::findAllSubdirectories ==> Missing folder HLT/Muon.Tracking/ValidationWRTtp !!!
%MSG
%MSG-w JetMETDQMPostProcessor:  JetMETDQMPostProcessor:JetMETPostVal@endJob  31-Jul-2017 14:15:24 CEST PostGlobalEndRun
cannot find directory: HLT/HLTJETMET , skipping
%MSG
%MSG-e DQMGenericClient:  DQMGenericClient:hltMuonEfficienciesMR@endJob  31-Jul-2017 14:15:57 CEST PostGlobalEndRun
 DQMGenericClient::findAllSubdirectories ==> Missing folder HLT/Muon/MR !!!
%MSG
%MSG-e DQMGenericClient:  HLTMuonRefMethod:hltMuonRefEfficienciesMR@endJob  31-Jul-2017 14:15:58 CEST PostGlobalEndRun
 DQMGenericClient::findAllSubdirectories ==> Missing folder HLT/Muon/MR !!!
%MSG
%MSG-e DQMGenericClient:   DQMGenericClient:double_soft_muon_backup_70_metpt_efficiency@endJob  31-Jul-2017 14:16:05 CEST PostGlobalEndRun
 DQMGenericClient::findAllSubdirectories ==> Missing folder HLT/SUSY/SOS/backup70/MET !!!
%MSG
%MSG-e DQMGenericClient:   DQMGenericClient:double_soft_muon_backup_90_metpt_efficiency@endJob  31-Jul-2017 14:16:05 CEST PostGlobalEndRun
 DQMGenericClient::findAllSubdirectories ==> Missing folder HLT/SUSY/SOS/backup90/MET !!!
%MSG

@ianna
Copy link
Contributor Author

ianna commented Aug 1, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21940/console Started: 2017/08/01 08:07

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2017

+1
Tested at: e6014ab
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19978/21940/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
46f824c
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19978/21940/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19978/21940/git-merge-result

@cmsbuild
Copy link
Contributor

Pull request #19978 was updated. @perrotta, @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @slava77 can you please check and sign again.

@ianna
Copy link
Contributor Author

ianna commented Aug 11, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 11, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22219/console Started: 2017/08/11 16:07

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pr-code-checks/PR-19978/58

@cmsbuild
Copy link
Contributor

+1
Tested at: 53d2e18
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19978/22219/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
56f2f72
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19978/22219/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19978/22219/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19978/22219/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2713569
  • DQMHistoTests: Total failures: 254
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2713126
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@perrotta
Copy link
Contributor

+1

  • Technical
  • No changes expected, none observed in jenkins tests

@ianna
Copy link
Contributor Author

ianna commented Aug 12, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5dacd27 into cms-sw:master Aug 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed geometry-approved orp-approved reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_3_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ianna @cmsbuild @perrotta @davidlange6