Added missing efficiency histograms. #19982
Conversation
|
A new Pull Request was created by @mohsinwaseem for master. It involves the following packages: DQMOffline/Trigger @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@mohsinwaseem, |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
@mtosi what increase in number of bins? |
|
this PR is not adding histograms ?
=> it will add bins !
…On Tue, Aug 1, 2017 at 11:51 AM, mohsinwaseem ***@***.***> wrote:
@mtosi <https://github.com/mtosi> what increase in number of bins?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19982 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt58ws3puzj61WPJ8r3hS1x7FhEDCkfks5sTvUogaJpZM4OogxN>
.
|
|
@mtosi |
|
I understand that both numerator and denominator were already there,
but aren't you adding the efficiency plot ?!?!!?!?!?
…On Tue, Aug 1, 2017 at 1:56 PM, mohsinwaseem ***@***.***> wrote:
@mtosi <https://github.com/mtosi>
This PR is adding efficiency histograms that were missing. The input num
and den histos were already present.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19982 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt588o5G-mM2NIxnn3S9SKsw7afTUjJks5sTxJ9gaJpZM4OogxN>
.
|
|
Comparison is ready Comparison Summary:
|
|
So there are four 1-D phi plots -> 32X4 = 128 Bins. This makes the total of 44768 bins. |
|
pardon me,
I think it is not clear to me "32
*4 = 128 Bins."*
* mia*
…On Tue, Aug 1, 2017 at 4:23 PM, mohsinwaseem ***@***.***> wrote:
So there are four 1-D phi plots -> 32
*4 = 128 Bins. For added 2-D plots, the bins added are as follows. 11
EtaPhi plots = 11*24
*32 = 8448 15 PtEta plots = 15*60
*24 = 21600 4 EtaPhiHep17 plots = 4*10
*18 = 720 3 PhiPhi plots = 3*32
*32 = 3072 3 PtHT plots = 3*60*60 = 10800
This makes the total of 44768 bins.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19982 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt58_oAHbg-wCUWHyKD1SB_YLm2zNoqks5sTzT-gaJpZM4OogxN>
.
|
|
I have edited the comment replacing * with X.
It means that the histogram for phi has 32 bins. there are total 4 histograms for phi that are added so it makes a total of 128 bins.
Similarly for 2-D histos, for instance EtaPhi plots have 24X32 bins. (24 for Eta and 32 for Phi). And there are 11 histograms so 11X24X32 makes 8448 bins.
and hence forth.
-----------------
Best Regards
Mohsin
________________________________
From: mia tosi [notifications@github.com]
Sent: 01 August 2017 16:30
To: cms-sw/cmssw
Cc: Mohsan Waseem Ather; Mention
Subject: Re: [cms-sw/cmssw] Added missing efficiency histograms. (#19982)
pardon me,
I think it is not clear to me "32
*4 = 128 Bins."*
* mia*
On Tue, Aug 1, 2017 at 4:23 PM, mohsinwaseem ***@***.***> wrote:
So there are four 1-D phi plots -> 32
*4 = 128 Bins. For added 2-D plots, the bins added are as follows. 11
EtaPhi plots = 11*24
*32 = 8448 15 PtEta plots = 15*60
*24 = 21600 4 EtaPhiHep17 plots = 4*10
*18 = 720 3 PhiPhi plots = 3*32
*32 = 3072 3 PtHT plots = 3*60*60 = 10800
This makes the total of 44768 bins.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19982 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt58_oAHbg-wCUWHyKD1SB_YLm2zNoqks5sTzT-gaJpZM4OogxN>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#19982 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AHi65FHOIaRbPFnU_D0VlcH1tsrzdwI_ks5sTzZtgaJpZM4OogxN>.
|
|
;)
thanks
mia
On Tue, Aug 1, 2017 at 4:46 PM, mohsinwaseem <notifications@github.com>
wrote:
…
I have edited the comment replacing * with X.
It means that the histogram for phi has 32 bins. there are total 4
histograms for phi that are added so it makes a total of 128 bins.
Similarly for 2-D histos, for instance EtaPhi plots have 24X32 bins. (24
for Eta and 32 for Phi). And there are 11 histograms so 11X24X32 makes 8448
bins.
and hence forth.
-----------------
Best Regards
Mohsin
________________________________
From: mia tosi ***@***.***
Sent: 01 August 2017 16:30
To: cms-sw/cmssw
Cc: Mohsan Waseem Ather; Mention
Subject: Re: [cms-sw/cmssw] Added missing efficiency histograms. (#19982)
pardon me,
I think it is not clear to me "32
*4 = 128 Bins."*
* mia*
On Tue, Aug 1, 2017 at 4:23 PM, mohsinwaseem ***@***.***>
wrote:
> So there are four 1-D phi plots -> 32
>
> *4 = 128 Bins. For added 2-D plots, the bins added are as follows. 11
> EtaPhi plots = 11*24
> *32 = 8448 15 PtEta plots = 15*60
> *24 = 21600 4 EtaPhiHep17 plots = 4*10
> *18 = 720 3 PhiPhi plots = 3*32
> *32 = 3072 3 PtHT plots = 3*60*60 = 10800
>
> This makes the total of 44768 bins.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#19982 (comment)>, or
mute
> the thread
> <https://github.com/notifications/unsubscribe-
auth/AEt58_oAHbg-wCUWHyKD1SB_YLm2zNoqks5sTzT-gaJpZM4OogxN>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://github.com/cms-
sw/cmssw/pull/19982#issuecomment-319387326>, or mute the thread<
https://github.com/notifications/unsubscribe-auth/AHi65FHOIaRbPFnU_
D0VlcH1tsrzdwI_ks5sTzZtgaJpZM4OogxN>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19982 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt586sNz07BCy0BDlgjDn4a1sWDVW1Pks5sTzpOgaJpZM4OogxN>
.
|
|
Pull request #19982 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again. |
|
no actually the number of bins has increased as a result of this new update that I just did. There were two files so I had to do them separately using online editor. I will quantify additional bins in a moment. |
|
please
…On Tue, Aug 1, 2017 at 5:36 PM, mohsinwaseem ***@***.***> wrote:
no actually the number of bins has increased as a result of this new
update that I just did. There were two files so I had to do them separately
using online editor.
I will quantify additional bins in a moment.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19982 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt584GbyPP0imYVNzCaqk09bAaWbXoKks5sT0YTgaJpZM4OogxN>
.
|
|
Additional bins in update. Total additional bins = 98 |
|
uhmm, sorry
98 is the number of extra histograms or extra bins ?
…On Tue, Aug 1, 2017 at 5:48 PM, mohsinwaseem ***@***.***> wrote:
4 jetMulti plots = 4X11 = 44
4 bjetMulti plots = 4X6 = 24
3 muMulti plots = 3X6 = 18
2 eleMulti plots = 2X6 = 12
Total additional bins = 98
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19982 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt58yYex-l6EVhdlMI32CVvKZIgLu-jks5sT0i5gaJpZM4OogxN>
.
|
|
number of extra bins from 13 histograms |
|
on top of the number you quoted before ?
…On Tue, Aug 1, 2017 at 6:22 PM, mohsinwaseem ***@***.***> wrote:
number of extra bins from 13 histograms
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19982 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt580rC35LCo_UH420PRh8YpfFxTawBks5sT1DPgaJpZM4OogxN>
.
|
|
yes |
|
I know it is a silly sum
but can you please answer to the question
w/ the final number of extra bins you are adding, please ?
thanks !
…On Tue, Aug 1, 2017 at 6:38 PM, mohsinwaseem ***@***.***> wrote:
yes
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19982 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt5854KONDSV2Xwbc-Bl6STDD2-uZ1dks5sT1R0gaJpZM4OogxN>
.
|
|
Sure, Added 1-D histograms: Added 2-D histograms Total number of additional bins = 44866 |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
No description provided.