PixelPhase Validation bin reduction and protection against memory leak.

[davidcarbonis]

Updated plots:

• Removed module level plots and replaced them with 1D plots per layer/disk, significantly reducing the number of bins used.
• Maps per module per ladder/blade now exist where appropriate to provide module information information without significantly increasing the budget akin to the old 1D module level plots.
• Removed ToF plots deemed not as useful as ToF vs r (i.e. ToF vs eta/phi/z) and removed negative axis range (which was originally present due to copying the range used by the old pixel) as PSimHits do not have negative ToFs (unlike SimHits).

Added memory leak protection:

• PR Introduce Run3 (post-LS2) workflow #19889 for Run 3 workflows exposed lack of check to ensure that associatorByHits does exist , which was raised in Added check to ensure simhit collection in pixel rechit validation exists #19811 (comment) . A check and exception message has been added to ensure that the program terminates safely, does not experience a memory leak and
• This does not resolve the non-existence of associatorByHits in the Run 3 workflow. It is believed that the case has been identified. @kpedro88 and @davidcarbonis are working on this and a separate PR is planned to be opened to resolve this.

Other outstanding issues:

• The random differences noted in Added check to ensure simhit collection in pixel rechit validation exists #19811 (comment) in "PixelPhase1V/Run summary/TrackingParticle" between unrelated PRs, have not been forgotten but still need to be understood.

@davidlange6: I shall provide bin info shortly.

@fioriNTU will be interested in this.

[cmsbuild]

A new Pull Request was created by @davidcarbonis (Alexander Morton) for master.

It involves the following packages:

Validation/SiPixelPhase1DigisV
Validation/SiPixelPhase1HitsV
Validation/SiPixelPhase1RecHitsV
Validation/SiPixelPhase1TrackClustersV

@kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[dmitrijus]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21960/console Started: 2017/08/01 16:49

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[kpedro88]

Missing trackAssociatorByHits in Run3 is now resolved in #19889. Given that the pixel validation/DQM is now relying on this, developers should consider reorganizing the sequences - currently the module is only present in the muon validation sequence (https://github.com/cms-sw/cmssw/blob/master/Validation/RecoMuon/python/muonValidation_cff.py).

[cmsbuild]

+1
Tested at: 8af2a3d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19992/21960/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
ff15bd6
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19992/21960/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19992/21960/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19992/21960/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 25
• DQMHistoTests: Total histograms compared: 2534154
• DQMHistoTests: Total failures: 75812
• DQMHistoTests: Total nulls: 3
• DQMHistoTests: Total successes: 2458158
• DQMHistoTests: Total skipped: 181
• DQMHistoTests: Total Missing objects: 0
• Checked 102 log files, 14 edm output root files, 25 DQM output files

[davidlange6]

+1