EMTF 2017 PR #5 - DQM #20006
EMTF 2017 PR #5 - DQM #20006
Conversation
|
A new Pull Request was created by @abrinke1 for master. It involves the following packages: DQM/L1TMonitor @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Hopefully a fairly straightforward update - and will be very useful for us to have in the online DQM! Please test :) |
|
+1 |
|
The tests are being triggered in jenkins. |
|
Pull request #20006 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn can you please check and sign again. |
|
Oops ... didn't mean to stop the tests - just found a small typo. Can we re-start the tests in jenkins? |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
please test |
|
Pull request #20006 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn can you please check and sign again. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20006/179 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20006/179/git-diff.patch In future, you can run |
|
+1 |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
+1 |
cmsbuild
added
fully-signed
l1-approved
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
|
Comparison is ready Comparison Summary:
|
Part 3 (really) of set of PRs following PR #19741 and #19743
PR #19744 is no longer necessary
PR #19928 (CondDB and O2O) will have to be revisited later
Big emulator PR yet to come
Updated EMTF DQM with several improvements:
Since the DQM is the only consumer of the unpacked "EMTFHit" and "EMTFTrack" collections, removed "EMTFHit2016" and "EMTFTrack2016" products from the unpacker.