Run2-hcx139 Add a HLT filter for Laser events in HCAL #20049

bsunanda · 2017-08-03T15:37:49Z

This filter will be used in making a new HLT for HCAL Laser events (in HB/HE/HF)

bsunanda · 2017-08-03T15:38:05Z

cmsbuild · 2017-08-03T15:38:09Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22067/console Started: 2017/08/03 18:22

cmsbuild · 2017-08-03T15:38:10Z

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

HLTrigger/special

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

Martin-Grunewald · 2017-08-03T15:45:11Z

HLTrigger/special/src/HLTHcalLaserMisfireFilter.cc

+}
+
+bool HLTHcalLaserMisfireFilter::hltFilter(edm::Event& iEvent, const edm::EventSetup&, trigger::TriggerFilterObjectWithRefs & filterproduct) const {
+


It dioes not make sense that this is an HLTFilter, rather than a normal EDFilter, as saveTags() does not make sense for DIGI collections.

cmsbuild · 2017-08-03T17:40:29Z

+1
Tested at: 01e54cc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20049/22067/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
cf6d2ab
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20049/22067/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20049/22067/git-merge-result

cmsbuild · 2017-08-03T17:40:32Z

Comparison job queued.

cmsbuild · 2017-08-03T18:38:41Z

Pull request #20049 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please check and sign again.

davidlange6 · 2017-08-03T18:42:48Z

please test

cmsbuild · 2017-08-03T18:43:04Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22073/console Started: 2017/08/03 20:43

bsunanda · 2017-08-03T18:59:37Z

@cmsbuild Please test

cmsbuild · 2017-08-03T19:00:03Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22076/console Started: 2017/08/03 21:01

cmsbuild · 2017-08-08T12:08:06Z

Pull request #20049 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please check and sign again.

cmsbuild · 2017-08-08T12:16:30Z

Pull request #20049 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please check and sign again.

bsunanda · 2017-08-08T12:16:32Z

@cmsbuild Please test

cmsbuild · 2017-08-08T12:16:45Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22139/console Started: 2017/08/08 14:17

bsunanda · 2017-08-08T14:54:07Z

@Martin-Grunewald @davidlange6 I made those changes as suggested by David - namely renamed the variable names for HF and giving some inline comment for the RBX's. Please sign these and get this integrated

cmsbuild · 2017-08-08T15:42:07Z

+1
Tested at: 530f7ad
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20049/22139/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
947a871
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20049/22139/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20049/22139/git-merge-result

cmsbuild · 2017-08-08T15:42:11Z

Comparison job queued.

cmsbuild · 2017-08-08T16:24:35Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20049/22139/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 25
DQMHistoTests: Total histograms compared: 2646495
DQMHistoTests: Total failures: 213
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2646101
DQMHistoTests: Total skipped: 181
DQMHistoTests: Total Missing objects: 0
Checked 102 log files, 14 edm output root files, 25 DQM output files

Martin-Grunewald · 2017-08-09T04:44:29Z

+1

cmsbuild · 2017-08-09T04:44:44Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

davidlange6 · 2017-08-09T07:10:07Z

+1

Run2-hcx140 Backport PR's #19574 and #20049 which provides two HLT filters (1) for selecting multiple L1 objects; (2) Laser firing in HCAL

Add a HLT filter for Laser events in HCAL

01e54cc

cmsbuild added this to the CMSSW_9_3_X milestone Aug 3, 2017

cmsbuild added comparison-pending hlt-pending orp-pending pending-signatures tests-pending labels Aug 3, 2017

cmsbuild added tests-started and removed tests-pending labels Aug 3, 2017

Martin-Grunewald reviewed Aug 3, 2017

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Aug 3, 2017

Sunanda added 2 commits August 3, 2017 20:26

Add the line for makeHLTFilterDescription

5ad408a

Changed to EDFilter

2c3f0a1

cmsbuild added tests-pending and removed tests-approved labels Aug 3, 2017

cmsbuild added tests-started and removed tests-pending labels Aug 3, 2017

cmsbuild added tests-pending and removed tests-started labels Aug 3, 2017

cmsbuild added hlt-pending pending-signatures tests-pending labels Aug 8, 2017

Comment on ieta,iphi values used

530f7ad

cmsbuild added tests-started and removed tests-pending labels Aug 8, 2017

cmsbuild added tests-approved and removed tests-started labels Aug 8, 2017

cmsbuild added comparison-available and removed comparison-pending labels Aug 8, 2017

cmsbuild added fully-signed hlt-approved and removed hlt-pending pending-signatures labels Aug 9, 2017

cmsbuild added orp-approved and removed orp-pending labels Aug 9, 2017

cmsbuild merged commit c74efe3 into cms-sw:master Aug 9, 2017

bsunanda mentioned this pull request Aug 17, 2017

Run2-hcx140 Backport PR's #19574 and #20049 which provides two HLT filters (1) for selecting multiple L1 objects; (2) Laser firing in HCAL #20065

Merged

cmsbuild added a commit that referenced this pull request Aug 22, 2017

Merge pull request #20065 from bsunanda/Run2-hcx140

44603af

Run2-hcx140 Backport PR's #19574 and #20049 which provides two HLT filters (1) for selecting multiple L1 objects; (2) Laser firing in HCAL

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run2-hcx139 Add a HLT filter for Laser events in HCAL #20049

Run2-hcx139 Add a HLT filter for Laser events in HCAL #20049

bsunanda commented Aug 3, 2017

bsunanda commented Aug 3, 2017

cmsbuild commented Aug 3, 2017 •

edited

cmsbuild commented Aug 3, 2017

Martin-Grunewald Aug 3, 2017 •

edited

cmsbuild commented Aug 3, 2017

cmsbuild commented Aug 3, 2017

cmsbuild commented Aug 3, 2017

davidlange6 commented Aug 3, 2017

cmsbuild commented Aug 3, 2017 •

edited

bsunanda commented Aug 3, 2017

cmsbuild commented Aug 3, 2017 •

edited

cmsbuild commented Aug 8, 2017

cmsbuild commented Aug 8, 2017

bsunanda commented Aug 8, 2017

cmsbuild commented Aug 8, 2017 •

edited

bsunanda commented Aug 8, 2017

cmsbuild commented Aug 8, 2017

cmsbuild commented Aug 8, 2017

cmsbuild commented Aug 8, 2017

Martin-Grunewald commented Aug 9, 2017

cmsbuild commented Aug 9, 2017

davidlange6 commented Aug 9, 2017

		}

		bool HLTHcalLaserMisfireFilter::hltFilter(edm::Event& iEvent, const edm::EventSetup&, trigger::TriggerFilterObjectWithRefs & filterproduct) const {

Run2-hcx139 Add a HLT filter for Laser events in HCAL #20049

Run2-hcx139 Add a HLT filter for Laser events in HCAL #20049

Conversation

bsunanda commented Aug 3, 2017

bsunanda commented Aug 3, 2017

cmsbuild commented Aug 3, 2017 • edited

cmsbuild commented Aug 3, 2017

Martin-Grunewald Aug 3, 2017 • edited

Choose a reason for hiding this comment

cmsbuild commented Aug 3, 2017

cmsbuild commented Aug 3, 2017

cmsbuild commented Aug 3, 2017

davidlange6 commented Aug 3, 2017

cmsbuild commented Aug 3, 2017 • edited

bsunanda commented Aug 3, 2017

cmsbuild commented Aug 3, 2017 • edited

cmsbuild commented Aug 8, 2017

cmsbuild commented Aug 8, 2017

bsunanda commented Aug 8, 2017

cmsbuild commented Aug 8, 2017 • edited

bsunanda commented Aug 8, 2017

cmsbuild commented Aug 8, 2017

cmsbuild commented Aug 8, 2017

cmsbuild commented Aug 8, 2017

Martin-Grunewald commented Aug 9, 2017

cmsbuild commented Aug 9, 2017

davidlange6 commented Aug 9, 2017

cmsbuild commented Aug 3, 2017 •

edited

Martin-Grunewald Aug 3, 2017 •

edited

cmsbuild commented Aug 3, 2017 •

edited

cmsbuild commented Aug 3, 2017 •

edited

cmsbuild commented Aug 8, 2017 •

edited