Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr92x L1T fix EMTF Unpacker RPC Bit Range #20054

Merged

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Aug 4, 2017

92x L1T EMTF Unpacker RPC Bit Range
No need for 93x PR (see below).

This will remove numerous printouts from L1T, currently appearing at Tier0 when processing 2017 data.

%MSG-e EMTF:  L1TRawToDigi:emtfStage2Digis 15-Jul-2017 14:50:46 CEST  Run: 298853 Event: 29487742
Format identifier bits in RPCd are incorrect
%MSG

Description:
In 92x, we are still using 2016 EMTF unpacker.
This fixes that EMTF unpacker to use the correct bit-range (4 to 15) when checking for unpacking RPC input data.

In 2017 data, the bit range (4 to 15) is used in the fw at P5. In 2016 data, the bit range {3 to 15) was used. So this fix will work on 2016 data as well.

There is no need for 93x PR as this fix is already included in the L1T EMTF 2017 emulator/unpacker
migration in CMSSW, and has already been merged in 93x. See here:
https://github.com/cms-sw/cmssw/blob/CMSSW_9_3_X/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockRPC.cc#L65

@cmsbuild cmsbuild added this to the CMSSW_9_2_X milestone Aug 4, 2017
@rekovic
Copy link
Contributor Author

rekovic commented Aug 4, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22084/console Started: 2017/08/04 11:27

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

A new Pull Request was created by @rekovic for CMSSW_9_2_X.

It involves the following packages:

EventFilter/L1TRawToDigi

@cmsbuild, @rekovic, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko, @thomreis this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@rekovic
Copy link
Contributor Author

rekovic commented Aug 4, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

Comparison job queued.

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 7f6dd26 into cms-sw:CMSSW_9_2_X Aug 4, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20054/22084/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1791774
  • DQMHistoTests: Total failures: 14524
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1777084
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants