New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pr92x L1T fix EMTF Unpacker RPC Bit Range #20054
pr92x L1T fix EMTF Unpacker RPC Bit Range #20054
Conversation
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @rekovic for CMSSW_9_2_X. It involves the following packages: EventFilter/L1TRawToDigi @cmsbuild, @rekovic, @mulhearn can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
merge |
Comparison is ready Comparison Summary:
|
92x L1T EMTF Unpacker RPC Bit Range
No need for 93x PR (see below).
This will remove numerous printouts from L1T, currently appearing at Tier0 when processing 2017 data.
Description:
In 92x, we are still using 2016 EMTF unpacker.
This fixes that EMTF unpacker to use the correct bit-range (4 to 15) when checking for unpacking RPC input data.
In 2017 data, the bit range (4 to 15) is used in the fw at P5. In 2016 data, the bit range {3 to 15) was used. So this fix will work on 2016 data as well.
There is no need for 93x PR as this fix is already included in the L1T EMTF 2017 emulator/unpacker
migration in CMSSW, and has already been merged in 93x. See here:
https://github.com/cms-sw/cmssw/blob/CMSSW_9_3_X/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockRPC.cc#L65