Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add built tracks back to trackingOnly MultiTrackValidator #20073

Merged
merged 1 commit into from Aug 9, 2017

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Aug 7, 2017

This PR adds back the built tracks MTV instance that was accidentally removed from trackingOnly sequence in #19582.

Tested in 9_3_0_pre2, no changes expected in standard workflows.

@rovere @VinInn @ebrondol

@makortel
Copy link
Contributor Author

makortel commented Aug 7, 2017

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2017

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

Validation/RecoTrack

@kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @wmtford, @ebrondol, @mtosi, @dgulhan this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Aug 7, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22126/console Started: 2017/08/07 15:36

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20073/22126/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2646495
  • DQMHistoTests: Total failures: 272
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2646042
  • DQMHistoTests: Total skipped: 181
  • DQMHistoTests: Total Missing objects: 0
  • Checked 102 log files, 14 edm output root files, 25 DQM output files

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 52deb34 into cms-sw:master Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants