Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to extend conddb dump command to new CondFormats #20091

Merged

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented Aug 9, 2017

This fix generalise the BuildFile template used in the locally compiled code.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2017

A new Pull Request was created by @ggovi for CMSSW_9_2_X.

It involves the following packages:

CondCore/Utilities

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@ggovi
Copy link
Contributor Author

ggovi commented Aug 9, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22160/console Started: 2017/08/09 11:30

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2017

Comparison job queued.

@ggovi
Copy link
Contributor Author

ggovi commented Aug 9, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20091/22160/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1791740
  • DQMHistoTests: Total failures: 29501
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1762073
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7a51fa4 into cms-sw:CMSSW_9_2_X Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants