Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport from 93X to 71X - for neutral non-detectable exotic - send their daughters to Geant4 #20108

Merged

Conversation

zhangzc11
Copy link
Contributor

PR in 93X: #20083

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2017

A new Pull Request was created by @zhangzc11 (Zhicai Zhang) for CMSSW_7_1_X.

It involves the following packages:

SimG4Core/Generators

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Aug 11, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 11, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22216/console Started: 2017/08/11 16:06

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20108/22216/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 13
  • DQMHistoTests: Total histograms compared: 842166
  • DQMHistoTests: Total failures: 4367
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 837331
  • DQMHistoTests: Total skipped: 468
  • DQMHistoTests: Total Missing objects: 0
  • Checked 51 log files, 14 edm output root files, 13 DQM output files

@civanch
Copy link
Contributor

civanch commented Aug 14, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@zhangzc11
Copy link
Contributor Author

@davidlange6 could you please approve this backport to 71X? we need this for 2016 MC production.

@zhangzc11
Copy link
Contributor Author

@davidlange6 Dear David, could you please approve this backport PR asap? Thanks a lot!

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7890a59 into cms-sw:CMSSW_7_1_X Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants