Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable ZS mark and pass for 2017 data. it affects pre-TS1 data only. #20115

Merged
merged 1 commit into from Aug 15, 2017

Conversation

deguio
Copy link
Contributor

@deguio deguio commented Aug 10, 2017

earlier this year we realized that there was an effective ZS applied at reco level for HF which was coming from the MarkAndPass flag being set in the RAW data. that flag is now unset and the HF is read and reconstructed in full readout for real starting from TS1. However, in order to recover the wanted non-suppressed behaviour in HF for the early 2017 data in the upcoming re-recos, we would like to merge this change.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @deguio (Federico De Guio) for master.

It involves the following packages:

RecoLocalCalo/HcalRecProducers

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mariadalfonso this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 10, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22195/console Started: 2017/08/10 16:49

@davidlange6
Copy link
Contributor

davidlange6 commented Aug 10, 2017 via email

@kpedro88
Copy link
Contributor

hfprereco is only used in 2017 onward, so I don't think the change needs to be isolated by an Era

@davidlange6
Copy link
Contributor

davidlange6 commented Aug 10, 2017 via email

@slava77
Copy link
Contributor

slava77 commented Aug 10, 2017

please provide some plots for expected changes in data and MC as a part of this PR description.

@deguio
Copy link
Contributor Author

deguio commented Aug 10, 2017

hi,
the change is motivated by the jetMet report at today's PPD. see for example slide 7 at:
https://indico.cern.ch/event/659010/contributions/2687022/attachments/1506909/2348470/PPD.pdf
for the coming rerecos their wish is to have this fixed for early 2017 data.

the impact in terms of number of rechits from HF can be seen at:
https://goo.gl/FahKEM
the run when the change at p5 happened is: 298653

no changes are expected in MC.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@slava77
Copy link
Contributor

slava77 commented Aug 10, 2017 via email

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor Author

deguio commented Aug 10, 2017

Hi,
ok, I don't have objections even if the schedule for the first re-reco seems tight.

let me just clarify that:

  • there is no effect on the current data taking. we are already running unsuppressed since after TS1
  • what comes with this PR is effectively the intended behaviour (no suppression in HF as in 2016)
  • the rechits in HF at the beginning of 2017 were suppressed by mistake. we are trying to recover the right behaviour for those data

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20115/22195/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 333 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2713569
  • DQMHistoTests: Total failures: 897
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 2712481
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@slava77
Copy link
Contributor

slava77 commented Aug 10, 2017 via email

@deguio deguio changed the title disable ZS mark and pass for 2017 disable ZS mark and pass for 2017 data pre-TS1 Aug 10, 2017
@deguio
Copy link
Contributor Author

deguio commented Aug 10, 2017

hi @slava77
yes: at the marking of the raw data was removed at p5 during TS1.
yes: this PR changes only the pre TS1 data.
2017C and later looks fine in prompt already: https://goo.gl/RUi5W8

@deguio deguio changed the title disable ZS mark and pass for 2017 data pre-TS1 disable ZS mark and pass for 2017 data. it affects pre-TS1 data only. Aug 10, 2017
@slava77
Copy link
Contributor

slava77 commented Aug 10, 2017 via email

@deguio
Copy link
Contributor Author

deguio commented Aug 11, 2017

right.
unfortunately I won't be able to join the reco meeting due to overlapping hcal dpg meetings.
please let us know if additional input is needed or if you think this can be considered for the release to be used for the re-recos.

thanks,
F.

@abdoulline

@deguio deguio closed this Aug 11, 2017
@deguio deguio reopened this Aug 11, 2017
@deguio
Copy link
Contributor Author

deguio commented Aug 11, 2017

(sorry, wrong button by mistake)

@perrotta
Copy link
Contributor

@deguio : could you please post here the address of one file from 2017C in which I can test this PR on the new data? Thank you

@slava77
Copy link
Contributor

slava77 commented Aug 13, 2017 via email

@deguio
Copy link
Contributor Author

deguio commented Aug 14, 2017

yeah, I confirm that. thanks @slava77

@perrotta
Copy link
Contributor

This PR, when run on 2017B data (200 events from wf 136.783 RunJetHT2017B) gives relevant differences. This is what expected when recovery the non suppressed behavior in HF, I imagine:

  • HFRecHitSorted energy:
    image

  • HFPreRecHitsSorted energy (this collecrtion almost doubles in number):
    image

  • Energy and eta of ak4PFJets:
    image
    image

@perrotta
Copy link
Contributor

When run on the same number of event (200) in data from RunJetHT2017C (run 299368, lumies 164-165) no difference is spot in the reco output, as anticipated by the proponents of this PR

@perrotta
Copy link
Contributor

+1

  • The effect on pre-TS1 data (2017B) is as expected from the description of this PR
  • No effect on pst-TS1 (2017C) data, as anticipated
  • Jenkins tests only report differences for 2017B data (e.g. RunSinglePh2017B136p788): no effect on MC wfs, as expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@deguio
Copy link
Contributor Author

deguio commented Aug 15, 2017

thanks @perrotta

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 3110ef9 into cms-sw:master Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants