New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CTPPS Pixel unpacker patch (backport) #20121
CTPPS Pixel unpacker patch (backport) #20121
Conversation
A new Pull Request was created by @fabferro (Fabrizio Ferro) for CMSSW_9_2_X. It involves the following packages: EventFilter/CTPPSRawToDigi @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
urgent a rough guess is that we may start having o(1%) failure rate per job in promptreco without this fix. |
backport of #20120 |
Comparison is ready Comparison Summary:
|
+1 |
adding small patch in the unpacker to prevent corrupted row/col from making the jobs crash (as in PR #20120 )