Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTPPS Pixel unpacker patch (backport) #20121

Merged
merged 2 commits into from Aug 11, 2017

Conversation

fabferro
Copy link
Contributor

adding small patch in the unpacker to prevent corrupted row/col from making the jobs crash (as in PR #20120 )

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 10, 2017

A new Pull Request was created by @fabferro (Fabrizio Ferro) for CMSSW_9_2_X.

It involves the following packages:

EventFilter/CTPPSRawToDigi

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @forthommel this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Aug 10, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 10, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22199/console Started: 2017/08/10 18:09

@cmsbuild
Copy link
Contributor

Pull request #20121 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20121/22199/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1791774
  • DQMHistoTests: Total failures: 150
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1791458
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@slava77
Copy link
Contributor

slava77 commented Aug 10, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 10, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22203/console Started: 2017/08/10 20:31

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@slava77
Copy link
Contributor

slava77 commented Aug 10, 2017

+1

for #20121 3529436

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@slava77
Copy link
Contributor

slava77 commented Aug 10, 2017

urgent

a rough guess is that we may start having o(1%) failure rate per job in promptreco without this fix.

@slava77
Copy link
Contributor

slava77 commented Aug 10, 2017

backport of #20120

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20121/22203/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1791774
  • DQMHistoTests: Total failures: 15035
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1776573
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a10d74d into cms-sw:CMSSW_9_2_X Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants