New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default radii for HGCAL layer and multi clustering #20131
Conversation
@edjtscott, CMSSW_9_3_X branch is closed for direct updates. cms-bot is going to move this PR to master branch. |
A new Pull Request was created by @edjtscott for master. It involves the following packages: RecoLocalCalo/HGCalRecProducers @perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pr-code-checks/PR-20131/60 |
@cmsbuild please test @felicepantaleo @rovere |
The tests are being triggered in jenkins. |
assign upgrade |
@slava77 this will only affect objects derived from multi-clustering within HGCal, namely the ones activated by #20045 |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
On the technical side:
|
+1 |
@davidlange6 |
merge |
Would like to change the default values for two sets of radii in the HGCAL clustering:
This makes more sense for hadronic objects (eg in the BH the cell sizes can be more than 2cm so the 2cm delta_c is silly) but is expected to have almost no effect on EM objects.
See plots here and here for the default and updated values respectively for unconverted pT 25 photons.