Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vertex filters rubust to L3Muon duplicates #20136

Conversation

aboletti
Copy link
Contributor

As spotted by FOG[1], these three filters are giving error any time in the hltIterL3MuonCandidates collection is present a duplicated objects. Some details are given in this[2] JIRA.

Since in presence of duplicates the filters will treat them correctly, the error message is restricted to the cases when the L3Muons matched to the two vertexing tracks are less then 2.

[1]
https://groups.cern.ch/group/cms-hlt/Lists/Archive/Flat.aspx?RootFolder=%2Fgroup%2Fcms%2Dhlt%2FLists%2FArchive%2FHLTDisplacedmumuFilter%20error%20in%20recent%20runs&FolderCTID=0x012002005CF9F426540B9C4D8205911CC3985E98
[2]
https://its.cern.ch/jira/browse/CMSMUONS-23

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aboletti for master.

It involves the following packages:

HLTrigger/btau

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@imarches, @acaudron, @Martin-Grunewald, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pr-code-checks/PR-20136/67

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/jenkins-artifacts/pr-code-checks/PR-20136/67/git-diff.patch

In future, you can run scram build code-checks to apply code checks

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 12, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22242/console Started: 2017/08/12 08:10

@cmsbuild
Copy link
Contributor

-1

Tested at: efa0d94

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
56f2f72
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20136/22242/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20136/22242/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20136/22242/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
136.731 step1

DAS Error

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
56f2f72
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20136/22242/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20136/22242/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@fwyzard
Copy link
Contributor

fwyzard commented Aug 12, 2017 via email

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 12, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22244/console Started: 2017/08/12 10:18

@cmsbuild
Copy link
Contributor

-1

Tested at: efa0d94

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
56f2f72
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20136/22244/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20136/22244/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20136/22244/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
136.731 step1

DAS Error

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
56f2f72
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20136/22244/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20136/22244/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

Pull request #20136 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please check and sign again.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20136/139

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20136/139/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20136/139/git-diff.patch | patch -p1

In future, you can run scram build code-checks to apply code checks

@cmsbuild
Copy link
Contributor

Pull request #20136 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please check and sign again.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20136/140

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20136/140/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20136/140/git-diff.patch | patch -p1

In future, you can run scram build code-checks to apply code checks

@Martin-Grunewald
Copy link
Contributor

@aboletti
Please apply suggested code changes (see above)!

@cmsbuild
Copy link
Contributor

Pull request #20136 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please check and sign again.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20136/173

@fwyzard
Copy link
Contributor

fwyzard commented Aug 17, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 17, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22354/console Started: 2017/08/17 06:08

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20136/22354/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2653169
  • DQMHistoTests: Total failures: 260
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2652720
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8e40a2d into cms-sw:master Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants