New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make vertex filters rubust to L3Muon duplicates #20136
Make vertex filters rubust to L3Muon duplicates #20136
Conversation
A new Pull Request was created by @aboletti for master. It involves the following packages: HLTrigger/btau @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-code-checks Logs: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pr-code-checks/PR-20136/67 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/jenkins-artifacts/pr-code-checks/PR-20136/67/git-diff.patch In future, you can run |
please test |
The tests are being triggered in jenkins. |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
@cmsbuild, please test
|
The tests are being triggered in jenkins. |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
Pull request #20136 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please check and sign again. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20136/139 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20136/139/git-diff.patch In future, you can run |
Pull request #20136 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please check and sign again. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20136/140 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20136/140/git-diff.patch In future, you can run |
@aboletti |
Pull request #20136 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please check and sign again. |
+code-checks |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
As spotted by FOG[1], these three filters are giving error any time in the hltIterL3MuonCandidates collection is present a duplicated objects. Some details are given in this[2] JIRA.
Since in presence of duplicates the filters will treat them correctly, the error message is restricted to the cases when the L3Muons matched to the two vertexing tracks are less then 2.
[1]
https://groups.cern.ch/group/cms-hlt/Lists/Archive/Flat.aspx?RootFolder=%2Fgroup%2Fcms%2Dhlt%2FLists%2FArchive%2FHLTDisplacedmumuFilter%20error%20in%20recent%20runs&FolderCTID=0x012002005CF9F426540B9C4D8205911CC3985E98
[2]
https://its.cern.ch/jira/browse/CMSMUONS-23