Make vertex filters rubust to L3Muon duplicates - 92X backport

[aboletti]

Backport of #20136

As spotted by FOG[1], these three filters are giving error any time in the hltIterL3MuonCandidates collection is present a duplicated objects. Some details are given in this[2] JIRA.

Since in presence of duplicates the filters will treat them correctly, the error message is restricted to the cases when the L3Muons matched to the two vertexing tracks are less then 2.

[1]
https://groups.cern.ch/group/cms-hlt/Lists/Archive/Flat.aspx?RootFolder=%2Fgroup%2Fcms%2Dhlt%2FLists%2FArchive%2FHLTDisplacedmumuFilter%20error%20in%20recent%20runs&FolderCTID=0x012002005CF9F426540B9C4D8205911CC3985E98
[2]
https://its.cern.ch/jira/browse/CMSMUONS-23

[cmsbuild]

A new Pull Request was created by @aboletti for CMSSW_9_2_X.

It involves the following packages:

HLTrigger/btau

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@imarches, @acaudron, @Martin-Grunewald, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

• Backported from Make vertex filters rubust to L3Muon duplicates #20136

[Martin-Grunewald]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22243/console Started: 2017/08/12 08:13

[cmsbuild]

-1

Tested at: 7d3afea

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
7130621
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20137/22243/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20137/22243/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20137/22243/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
136.731 step1

DAS Error

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
7130621
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20137/22243/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20137/22243/git-merge-result

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[Martin-Grunewald]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22270/console Started: 2017/08/14 09:56

[cmsbuild]

+1
Tested at: 7d3afea
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20137/22270/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
69bf76d
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20137/22270/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20137/22270/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Pull request #20137 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please check and sign again.

[Martin-Grunewald]

@aboletti
Please apply suggested code changes (see #20136 )

[cmsbuild]

Pull request #20137 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please check and sign again.

[fwyzard]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22355/console Started: 2017/08/17 06:11

[cmsbuild]

+1
Tested at: edf9fe3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20137/22355/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
6b21c06
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20137/22355/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20137/22355/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20137/22355/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 22
• DQMHistoTests: Total histograms compared: 1791808
• DQMHistoTests: Total failures: 29449
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1762193
• DQMHistoTests: Total skipped: 166
• DQMHistoTests: Total Missing objects: 0
• Checked 90 log files, 14 edm output root files, 22 DQM output files

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1