Minor Modifications to Trigger Automated Clang Checks #20175

ianna · 2017-08-15T14:06:42Z

Cleanup and formating

ianna · 2017-08-15T14:06:52Z

please test

cmsbuild · 2017-08-15T14:07:00Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22312/console Started: 2017/08/15 16:07

cmsbuild · 2017-08-15T14:07:01Z

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/Parser
DetectorDescription/RegressionTest

@cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2017-08-15T14:11:33Z

-1

Tested at: 946138d

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
7d6f190
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20175/22312/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20175/22312/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20175/22312/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found an error when building:

>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-15-1100/src/DetectorDescription/RegressionTest/src/TinyDomTest.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-15-1100/src/DetectorDescription/RegressionTest/src/ddstats.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-15-1100/src/DetectorDescription/RegressionTest/src/DDCompareTools.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-15-1100/src/DetectorDescription/RegressionTest/src/DDErrorDetection.cc 
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-15-1100/src/DetectorDescription/RegressionTest/src/DDHtmlFormatter.cc: In function 'void dd_to_html(DDHtmlDetails&)':
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-15-1100/src/DetectorDescription/RegressionTest/src/DDHtmlFormatter.cc:306:33: error: 'mkdir' was not declared in this scope
   mkdir( category.c_str(), 0755 );
                                 ^
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-15-1100/src/DetectorDescription/RegressionTest/src/SaxToDom.cc 
Entering library rule at src/DetectorDescription/RegressionTest/plugins
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-15-1100/src/DetectorDescription/RegressionTest/bin/DDErrorReport.cpp

Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 16 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-15-1100/src/DetectorDescription/RegressionTest/test/tutorial.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-15-1100/src/DetectorDescription/RegressionTest/test/reg_ddcore.cpp 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-15-1100/src/DetectorDescription/RegressionTest/test/TestIntegration.cpp 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-15-1100/src/DetectorDescription/RegressionTest/test/const_dump.cpp 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-15-1100/src/DetectorDescription/RegressionTest/test/reg_ddparser.cpp 
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-15-1100/src/DetectorDescription/RegressionTest/src/DDHtmlFormatter.cc:306:3: error: use of undeclared identifier 'mkdir'
  mkdir( category.c_str(), 0755 );
  ^
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-08-15-1100/src/DetectorDescription/RegressionTest/src/DDHtmlFormatter.cc:323:5: error: use of undeclared identifier 'mkdir'
    mkdir( dir.c_str(), 0755 );
    ^

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
7d6f190
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20175/22312/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20175/22312/git-merge-result

cmsbuild · 2017-08-15T14:11:35Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2017-08-15T14:18:30Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20175/123

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20175/123/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20175/123/git-diff.patch | patch -p1

In future, you can run scram build code-checks to apply code checks

ianna · 2017-08-15T14:34:35Z

please test

cmsbuild · 2017-08-15T14:34:43Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22316/console Started: 2017/08/15 16:37

cmsbuild · 2017-08-15T14:34:44Z

Pull request #20175 was updated. @cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please check and sign again.

cmsbuild · 2017-08-15T18:12:37Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20175/22316/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2718193
DQMHistoTests: Total failures: 282
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2717722
DQMHistoTests: Total skipped: 189
DQMHistoTests: Total Missing objects: 0
Checked 107 log files, 14 edm output root files, 26 DQM output files

ianna · 2017-08-16T09:16:59Z

please test

cmsbuild · 2017-08-16T09:17:04Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22338/console Started: 2017/08/16 11:17

cmsbuild · 2017-08-16T09:17:05Z

Pull request #20175 was updated. @cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please check and sign again.

cmsbuild · 2017-08-16T09:19:14Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20175/154

cmsbuild · 2017-08-16T11:00:14Z

+1
Tested at: 4e7f842
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20175/22338/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
512d77c
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20175/22338/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20175/22338/git-merge-result

cmsbuild · 2017-08-16T11:00:17Z

Comparison job queued.

ianna · 2017-08-16T12:25:00Z

+1

cmsbuild · 2017-08-16T12:27:09Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2017-08-16T12:36:49Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20175/22338/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2719094
DQMHistoTests: Total failures: 250
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2718655
DQMHistoTests: Total skipped: 189
DQMHistoTests: Total Missing objects: 0
Checked 107 log files, 14 edm output root files, 26 DQM output files

davidlange6 · 2017-08-16T15:06:57Z

merge

Minor modifications to trigger automated clang checks

946138d

cmsbuild added this to the CMSSW_9_3_X milestone Aug 15, 2017

cmsbuild added comparison-pending geometry-pending orp-pending pending-signatures tests-pending labels Aug 15, 2017

cmsbuild added tests-started and removed tests-pending labels Aug 15, 2017

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Aug 15, 2017

ianna closed this Aug 15, 2017

ianna reopened this Aug 15, 2017

Add Parser and OfflineDBLoader packages

a9a408f

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Aug 15, 2017

cmsbuild removed the tests-pending label Aug 15, 2017

cmsbuild added the tests-approved label Aug 15, 2017

cmsbuild added comparison-available and removed comparison-pending labels Aug 15, 2017

Fix code style and quality issues

4e7f842

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Aug 16, 2017

cmsbuild added tests-started and removed tests-pending labels Aug 16, 2017

cmsbuild added tests-approved and removed tests-started labels Aug 16, 2017

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels Aug 16, 2017

cmsbuild added comparison-available and removed comparison-pending labels Aug 16, 2017

cmsbuild merged commit 6fde6d9 into cms-sw:master Aug 16, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Minor Modifications to Trigger Automated Clang Checks #20175

Minor Modifications to Trigger Automated Clang Checks #20175

ianna commented Aug 15, 2017

ianna commented Aug 15, 2017

cmsbuild commented Aug 15, 2017 •

edited

cmsbuild commented Aug 15, 2017

cmsbuild commented Aug 15, 2017

cmsbuild commented Aug 15, 2017

cmsbuild commented Aug 15, 2017

ianna commented Aug 15, 2017

cmsbuild commented Aug 15, 2017 •

edited

cmsbuild commented Aug 15, 2017

cmsbuild commented Aug 15, 2017

ianna commented Aug 16, 2017

cmsbuild commented Aug 16, 2017 •

edited

cmsbuild commented Aug 16, 2017

cmsbuild commented Aug 16, 2017

cmsbuild commented Aug 16, 2017

cmsbuild commented Aug 16, 2017

ianna commented Aug 16, 2017

cmsbuild commented Aug 16, 2017

cmsbuild commented Aug 16, 2017

davidlange6 commented Aug 16, 2017

Minor Modifications to Trigger Automated Clang Checks #20175

Minor Modifications to Trigger Automated Clang Checks #20175

Conversation

ianna commented Aug 15, 2017

ianna commented Aug 15, 2017

cmsbuild commented Aug 15, 2017 • edited

cmsbuild commented Aug 15, 2017

cmsbuild commented Aug 15, 2017

cmsbuild commented Aug 15, 2017

cmsbuild commented Aug 15, 2017

ianna commented Aug 15, 2017

cmsbuild commented Aug 15, 2017 • edited

cmsbuild commented Aug 15, 2017

cmsbuild commented Aug 15, 2017

ianna commented Aug 16, 2017

cmsbuild commented Aug 16, 2017 • edited

cmsbuild commented Aug 16, 2017

cmsbuild commented Aug 16, 2017

cmsbuild commented Aug 16, 2017

cmsbuild commented Aug 16, 2017

ianna commented Aug 16, 2017

cmsbuild commented Aug 16, 2017

cmsbuild commented Aug 16, 2017

davidlange6 commented Aug 16, 2017

cmsbuild commented Aug 15, 2017 •

edited

cmsbuild commented Aug 15, 2017 •

edited

cmsbuild commented Aug 16, 2017 •

edited