Cleanup suggested by scram b code-checks #20199
Conversation
Replaced virtual with override where appropriate, use nullptr instead of 0, and use empty instead of size. Needed to manually fix the indentation in multiple places, the rest of the changes were automated.
|
A new Pull Request was created by @wddgit (W. David Dagenhart) for master. It involves the following packages: FWCore/ParameterSet @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
cmsbuild
added
core-pending
pending-signatures
tests-pending
and removed
core-approved
fully-signed
tests-approved
labels
|
Pull request #20199 was updated. @cmsbuild, @smuzaffar, @Dr15Jones can you please check and sign again. |
|
+code-checks |
|
The code-checks script missed some places that needed the same fixes in related classes in the same package so I added those by hand as well. I am presuming they were missed because they are template classes only used in tests in another package. |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
The unit test failure is not related to this PR. |
|
merge |
Replaced virtual with override where appropriate, use nullptr
instead of 0, and use empty instead of size.
Needed to manually fix the indentation in multiple places, the
rest of the changes were automated.