Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[92X] Offline DQM extensions for L1T EGamma (calo layer 2) and fixes - backport #20232

Merged
merged 8 commits into from Oct 5, 2017

Conversation

kreczko
Copy link
Contributor

@kreczko kreczko commented Aug 22, 2017

Backport of PR #20227 (Jira ticket CMSLITDPG-171).

The main PR is not merged yet, this backport might receive code changes based on the review of the main PR.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 22, 2017

A new Pull Request was created by @kreczko (Luke Kreczko) for CMSSW_9_2_X.

It involves the following packages:

DQMOffline/L1Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn can you please review it and eventually sign? Thanks.
@thomreis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@rekovic
Copy link
Contributor

rekovic commented Sep 12, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 12, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22906/console Started: 2017/09/12 17:54

@rekovic
Copy link
Contributor

rekovic commented Sep 12, 2017

@kreczko
Please change the title to "[92X] Offline DQM extensions for L1T EGamma (calo layer 2) and fixes - backport"

@kreczko kreczko changed the title [92X] Backport of PR #20227 (Jira ticket CMSLITDPG-171) [92X] Offline DQM extensions for L1T EGamma (calo layer 2) and fixes - backport Sep 12, 2017
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20232/22906/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1904066
  • DQMHistoTests: Total failures: 44228
  • DQMHistoTests: Total nulls: 437
  • DQMHistoTests: Total successes: 1859227
  • DQMHistoTests: Total skipped: 174
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@rekovic
Copy link
Contributor

rekovic commented Sep 19, 2017

+1

@cmsbuild
Copy link
Contributor

Pull request #20232 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn can you please check and sign again.

@kreczko
Copy link
Contributor Author

kreczko commented Sep 21, 2017

As @dmitrijus suggested, I've added the code-checks commit now as well.

@rekovic & @dmitrijus please resign.

@rekovic
Copy link
Contributor

rekovic commented Sep 25, 2017

please test

@rekovic
Copy link
Contributor

rekovic commented Sep 25, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 25, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23204/console Started: 2017/09/25 13:10

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20232/23204/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1903982
  • DQMHistoTests: Total failures: 15036
  • DQMHistoTests: Total nulls: 437
  • DQMHistoTests: Total successes: 1888335
  • DQMHistoTests: Total skipped: 174
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c4c0c92 into cms-sw:CMSSW_9_2_X Oct 5, 2017
@kreczko kreczko deleted the kreczko/jira/CMSLITDPG-171-92X branch October 6, 2017 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants